Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2tcp: init at 0.5 #81895

Merged
merged 2 commits into from Mar 17, 2020
Merged

http2tcp: init at 0.5 #81895

merged 2 commits into from Mar 17, 2020

Conversation

@clkamp
Copy link
Contributor

clkamp commented Mar 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
src = fetchgit {
inherit rev;
url = "git://git.subdivi.de/~helmut/wsgitools.git";
sha256 = "17i939zlk5k1hai51qyhm234fi7f0xc83qgh14r396khg9zsjjnw";
};
Comment on lines 11 to 13

This comment has been minimized.

Copy link
@jonringer

jonringer Mar 6, 2020

Contributor

can they do a new release on pypi? https://pypi.org/project/wsgitools/ seems 5 years out of date anyway

This comment has been minimized.

Copy link
@clkamp

clkamp Mar 9, 2020

Author Contributor

For http2tcp there is already a new release, for wsgitools I have asked for one.

This comment has been minimized.

Copy link
@clkamp

clkamp Mar 9, 2020

Author Contributor

For http2tcp there is already a new release, for wsgitools I have asked for one.

This comment has been minimized.

Copy link
@clkamp

clkamp Mar 11, 2020

Author Contributor

Now wsgitools comes from pypi at 0.3.1

@clkamp clkamp force-pushed the clkamp:http2tcp-add branch from 5c5aaea to f797a82 Mar 9, 2020
@clkamp clkamp changed the title http2tcp: init at 0.4postgit20190303 http2tcp: init at 0.5 Mar 9, 2020
@clkamp clkamp force-pushed the clkamp:http2tcp-add branch from f797a82 to 603acd0 Mar 11, 2020
@clkamp clkamp requested a review from jonringer Mar 11, 2020
}:

python3Packages.buildPythonApplication rec {

This comment has been minimized.

Copy link
@jonringer

jonringer Mar 11, 2020

Contributor
Suggested change

propagatedBuildInputs = with python3Packages; [ wsgitools ];

format = "other";

This comment has been minimized.

Copy link
@jonringer

jonringer Mar 11, 2020

Contributor
Suggested change
format = "other";
installPhase = ''
mkdir -p $out/{bin,share/${pname}}
cp http2tcp* $out/bin
cp Protocol $out/share/${pname}/
'';
Comment on lines +22 to +28

This comment has been minimized.

Copy link
@jonringer

jonringer Mar 11, 2020

Contributor

this doesn't look to be a normal python installation, you probably want to wrap the program with a python interpreter using python.withPackage https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#pythonwithpackages-function

This comment has been minimized.

Copy link
@clkamp

clkamp Mar 17, 2020

Author Contributor

I have changed it that way

Christian Lütke-Stetzkamp
@clkamp clkamp force-pushed the clkamp:http2tcp-add branch from 603acd0 to c550043 Mar 17, 2020
@clkamp clkamp requested a review from jonringer Mar 17, 2020
Copy link
Contributor

jonringer left a comment

diff LGTM
shows usage

[7 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81895
4 package built:
http2tcp python27Packages.wsgitools python37Packages.wsgitools python38Packages.wsgitools
@jonringer
Copy link
Contributor

jonringer commented Mar 17, 2020

@GrahamcOfBorg build http2tcp python27Packages.wsgitools python37Packages.wsgitools python38Packages.wsgitools

@jonringer jonringer merged commit 403a4b1 into NixOS:master Mar 17, 2020
17 of 18 checks passed
17 of 18 checks passed
http2tcp, python27Packages.wsgitools, python37Packages.wsgitools, python38Packages.wsgitools on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
http2tcp on aarch64-linux Success
Details
http2tcp on x86_64-linux Success
Details
http2tcp, python27Packages.wsgitools, python37Packages.wsgitools, python38Packages.wsgitools on aarch64-linux Success
Details
http2tcp, python27Packages.wsgitools, python37Packages.wsgitools, python38Packages.wsgitools on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.