Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] Backport protonvpn cli ng version 2.2.2 #81937

Conversation

@JeffLabonte
Copy link
Contributor

JeffLabonte commented Mar 6, 2020

Motivation for this change

protonvpn-cli is not supported anymore by protonvpn. protonvpn-cli-ng is the cli recommanded by ProtonVPN

Things done

Bring init from PR #77407 and update to 2.2.2 from PR #81735

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
jtcoolen and others added 2 commits Jan 9, 2020
Take the supported version of protonvpn

(cherry picked from commit b45c4d2)
Reason: protonvpn-cli is not supported anymore, it has been replaced by
this package
Simply keep up to date the cli since it is used to connect to a VPN.

(cherry picked from commit eb96574)
Reason: A tool to communicate with a VPN provider should be kept
up-to-date
@JeffLabonte JeffLabonte changed the title Backport protonvpn cli ng 2.2.0 to 2.2.2 [19.09] Backport protonvpn cli ng version 2.2.2 Mar 6, 2020
@JeffLabonte
Copy link
Contributor Author

JeffLabonte commented Mar 7, 2020

Error in PR, fixed in another branch!

@JeffLabonte JeffLabonte closed this Mar 7, 2020
@JeffLabonte JeffLabonte deleted the JeffLabonte:backport-protonvpn-cli-ng-2.2.0_to_2.2.2 branch Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.