Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] backport protonvpn cli ng #81952

Merged

Conversation

@JeffLabonte
Copy link
Contributor

JeffLabonte commented Mar 7, 2020

Motivation for this change

protonvpn-cli is not supported anymore by protonvpn. protonvpn-cli-ng is the cli recommanded by ProtonVPN

(see https://github.com/ProtonVPN/protonvpn-cli-ng).

Things done

For pythondialog, it brings init from PR #68636 and update from #75361 and #76059 .
For protonvpn-cli-ngL it brings init from PR #77407 and update to 2.2.2 from PR #81735 .

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
mbrgm and others added 5 commits Sep 13, 2019
This is required to install protonvpn-cli-ng

(cherry picked from commit ebaedb0)
Reason: The supported version of protonvpn-cli-ng requires this
dependency
Keep the version of pythondialog up-to-date

(cherry picked from commit 875524d)
Reason: Required for the supported version of protonvpn-cli-ng
Take it to the latest version!

(cherry picked from commit f41e2ca)
Reason: Keep the latest version for protonvpn-cli-ng
Take the supported version of protonvpn

(cherry picked from commit b45c4d2)
Reason: protonvpn-cli is not supported anymore, it has been replaced by
this package
Simply keep up to date the cli since it is used to connect to a VPN.

(cherry picked from commit eb96574)
Reason: A tool to communicate with a VPN provider should be kept
up-to-date
@JeffLabonte JeffLabonte requested a review from FRidh as a code owner Mar 7, 2020
@ofborg ofborg bot requested a review from jtcoolen Mar 7, 2020
@FRidh FRidh merged commit a81842b into NixOS:release-19.09 Mar 7, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
protonvpn-cli-ng, python on aarch64-linux Success
Details
protonvpn-cli-ng, python on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.