Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paperwork update #81969

Closed
wants to merge 3 commits into from
Closed

Paperwork update #81969

wants to merge 3 commits into from

Conversation

@symphorien
Copy link
Contributor

symphorien commented Mar 7, 2020

See #81921, which I closed involuntarily.

Nadrieril added 3 commits Mar 7, 2020
Also install paperwork-shell and desktop file
It is only used for paperwork and is now unmaintained.
@aszlig
Copy link
Member

aszlig commented Mar 7, 2020

@symphorien: Currently on the road, will review tomorrow. Thanks for the pull request.

# paperwork-shell install copies everything to $HOME/.local/share instead of $out/share
mkdir -p home/.local
mkdir -p $out/share
ln -s $out/share home/.local/share
HOME=$(readlink -f home) $out/bin/paperwork-shell install
Comment on lines +61 to +65

This comment has been minimized.

Copy link
@aszlig

aszlig Mar 9, 2020

Member

What about the following instead?

Suggested change
# paperwork-shell install copies everything to $HOME/.local/share instead of $out/share
mkdir -p home/.local
mkdir -p $out/share
ln -s $out/share home/.local/share
HOME=$(readlink -f home) $out/bin/paperwork-shell install
XDG_DATA_HOME="$out/share" "$out/bin/payperwork-shell" install

Also, did you check whether payperwork-shell actually works at runtime?

This comment has been minimized.

Copy link
@symphorien

symphorien Mar 9, 2020

Author Contributor

yes your suggestion works :)
(minus the typo)

about paperwork-shell: yes, for example result/bin/paperwork-shell chkdeps paperwork works whereas it used to complain about a missing paperwork module.

@symphorien
Copy link
Contributor Author

symphorien commented Mar 9, 2020

And now that I once again failed at git, I have to close this pull request and reopen a new one. Sorry for the inconvenience.

@symphorien symphorien closed this Mar 9, 2020
@symphorien symphorien mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.