Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zxcvbn-hs & zxcvbn-dvorak #81978

Merged
merged 2 commits into from Mar 7, 2020
Merged

Conversation

@timds
Copy link
Contributor

timds commented Mar 7, 2020

Motivation for this change

The zxcvbn-hs and zxcvbn-dvorak packages work fine, so I unmarked them as broken.

> nix-build --no-out-link -A haskellPackages.zxcvbn-dvorak --arg config '{ allowBroken = true; }'
/nix/store/nfkq4fdszd7xd060rkiwvkajbgdj36d9-zxcvbn-dvorak-0.1.0.0

> nix-build --no-out-link -A haskellPackages.zxcvbn-hs --arg config '{ allowBroken = true; }'
/nix/store/cwxs6z1kj48jrkn7nf4rik59vxb6wfvz-zxcvbn-hs-0.2.1.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@timds timds requested review from cdepillabout and Infinisil as code owners Mar 7, 2020
@cdepillabout
Copy link
Member

cdepillabout commented Mar 7, 2020

Looks good to me!

Both these packages compile on my machine.

@cdepillabout cdepillabout merged commit b67f95a into NixOS:haskell-updates Mar 7, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.