Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: consistent downloads.haskell.org src URLs #81983

Merged
merged 1 commit into from Mar 7, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented Mar 7, 2020

Consistency is good in general and these seem to work just as well as the
others, but it also helps with blacklisting package updates, as in:
ryantm/nixpkgs-update#160

CC @peti @ryantm @cdepillabout

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Consistency is good in general and these seem to work just as well as the
others, but it also helps with blacklisting package updates, as in:
ryantm/nixpkgs-update#160
@bhipple bhipple requested a review from cdepillabout as a code owner Mar 7, 2020
@bhipple
Copy link
Contributor Author

bhipple commented Mar 7, 2020

@GrahamcOfBorg build haskellPackages.ghc_8_6_5.src

@ofborg ofborg bot added the 6.topic: haskell label Mar 7, 2020
@peti peti merged commit 0ba1c9f into NixOS:master Mar 7, 2020
4 of 6 checks passed
4 of 6 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haskellPackages.ghc_8_6_5.src on aarch64-linux Success
Details
haskellPackages.ghc_8_6_5.src on x86_64-linux Success
Details
@bhipple bhipple deleted the bhipple:feature/ghc-urls branch May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.