Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch-bin: init at 1.4.0 #81996

Closed
wants to merge 1 commit into from
Closed

pytorch-bin: init at 1.4.0 #81996

wants to merge 1 commit into from

Conversation

@eadwu
Copy link
Member

eadwu commented Mar 7, 2020

Not perfect, literally clumped together by copying bits from tensorflow-bin.

Motivation for this change

But in case anyone comes by and wants a CUDA-enabled pytorch without compiling from source for Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bhipple
Copy link
Contributor

bhipple commented May 3, 2020

I would prefer that we just take the pytorch built cleanly from source. I'm working on getting #75827 polished up, at which point I don't think we'll need this.

@eadwu eadwu closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.