Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eigen: fetch source from gitlab #81998

Merged
merged 1 commit into from Mar 8, 2020
Merged

Conversation

@eadwu
Copy link
Member

eadwu commented Mar 7, 2020

@svanderburg @7c6f434c

Motivation for this change

Migrated over to Gitlab.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested review from svanderburg and 7c6f434c Mar 7, 2020
@eadwu eadwu changed the base branch from master to staging Mar 7, 2020
@eadwu eadwu force-pushed the eadwu:eigen/gitlab-source branch from 9df5356 to ebd4e4b Mar 7, 2020
@eadwu
Copy link
Member Author

eadwu commented Mar 7, 2020

There seems to be a lot of rebuilds just from changing the src. I guess this would be better after a new version releases?

@eadwu eadwu force-pushed the eadwu:eigen/gitlab-source branch from ebd4e4b to 805e068 Mar 7, 2020
Staging automation moved this from Needs review to Ready Mar 7, 2020
@veprbl
veprbl approved these changes Mar 7, 2020
Copy link
Member

veprbl left a comment

Diff between old unpacked tarball and the new source is minimal

# diff -aru eigen-eigen-b23437e61a07 /nix/store/6kix5k88g20hxhszdxh0kc4jpiz9smvb-source
Only in eigen-eigen-b23437e61a07: .hg_archival.txt
Only in eigen-eigen-b23437e61a07: .hgtags
@markuskowa markuskowa merged commit fd48d9b into NixOS:staging Mar 8, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
eigen on aarch64-linux Success
Details
eigen on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Ready to Done Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.