Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nemu: Init at 2.3.0 #82004

Open
wants to merge 3 commits into
base: master
from
Open

nemu: Init at 2.3.0 #82004

wants to merge 3 commits into from

Conversation

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Mar 7, 2020

Can someone help me with the install step here?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
++ (lib.optional withDbus "-DNM_WITH_DBUS=ON")
;

installPhase = ''

This comment has been minimized.

Copy link
@doronbehar

doronbehar Mar 8, 2020

Contributor

Upstream doesn't know how to write CMakeLists.txt. The following warning messages in configurePhase indicate this:

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_CXX_COMPILER
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DOCDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_INFODIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_LOCALEDIR
    CMAKE_INSTALL_MANDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR

And it's notable when reading this:

https://github.com/nemuTUI/nemu/blob/1633a9ecb2b9b036a01a5dbeddb21787680064ec/CMakeLists.txt#L24-L36

I say - report this upstream and once fixed, use a fetchpatch remove the installPhase override.

This comment has been minimized.

Copy link
@jtojnar

jtojnar Mar 8, 2020

Contributor

In particular, most of these are caused not using GNUInstallDirs cmake module.

This comment has been minimized.

Copy link
@grafin

grafin Mar 11, 2020

We updated our CMakeLists.txt
nemuTUI/nemu@a3f179a

Can you guys check if it's ok in current state, if so, we can make a new release for your package

This comment has been minimized.

Copy link
@doronbehar

doronbehar Mar 11, 2020

Contributor

Evaluation has failed: https://gist.github.com/f2bfb5498488aa5d2895bcbcace14e8d because of libudev argument not suppliled.

@caadar
Copy link
Contributor

caadar commented Mar 10, 2020

Ah! Some time ago tried packaging nEMU but not finished it...
You may look at my nemu-nix if interested.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Integrate changes from

    https://github.com/caadar/nemu-nix/blob/master/nemu.nix

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.