Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd: Fix stuck login command #82009

Open
wants to merge 1 commit into
base: master
from

Conversation

@shahrukh330
Copy link
Contributor

shahrukh330 commented Mar 7, 2020

Motivation for this change

Moving to go modules introduced a bug due to dependency mismatch. login command used to get stuck indefinitely.

Things done

Patches out problematic part of the code as a temp hack.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@shahrukh330 shahrukh330 force-pushed the shahrukh330:argo-fix-login-cmd branch from 269a2ca to c8a3843 Mar 7, 2020
@ofborg ofborg bot requested a review from kalbasit Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.