Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heatseeker: 1.5.1 -> 1.7.1 #82017

Merged
merged 1 commit into from Mar 9, 2020
Merged

heatseeker: 1.5.1 -> 1.7.1 #82017

merged 1 commit into from Mar 9, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented Mar 7, 2020

The build is currently broken on master; upgrading fixes it. Also upgrading the
cargoSha256 for #79975 and quoting the
homepage for NixOS/rfcs#45

Minus the cargo sha and fetcher change, this should be backported to 20.03 for
ZHF: #80379

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The build is currently broken on master; upgrading fixes it.
@marsam marsam merged commit e54d71c into NixOS:master Mar 9, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
heatseeker on aarch64-linux Success
Details
heatseeker on x86_64-linux Success
Details
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 9, 2020
Backport of NixOS#82017

ZHF: NixOS#80379

(cherry picked from commit 9044bde)
@michaelpj
Copy link
Contributor

michaelpj commented Mar 9, 2020

Why did you make this rather than merging my PR which you reviewed? #80539

@bhipple
Copy link
Contributor Author

bhipple commented Mar 9, 2020

Sorry, I just forgot about the other PR and somehow missed it in my scanning-for-dups scripts!

@michaelpj
Copy link
Contributor

michaelpj commented Mar 9, 2020

No worries :)

@bhipple
Copy link
Contributor Author

bhipple commented Mar 9, 2020

Do you still need to send your patch for the tty? It seems to build and pass its tests just fine as-is, but I haven't stress tested actual package usage much (this is one PR in a series of 200+ for a general sweep of the Rust infra).

@michaelpj
Copy link
Contributor

michaelpj commented Mar 9, 2020

Ah yes, you still need the patch. It fails at runtime without it. I guess the tests don't exercise that case!

I haven't actually sent a patch upstream since I don't know how to patch it properly, the fix I did in the other PR is Nix-specific.

@bhipple bhipple deleted the bhipple:u/heatseeker branch Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.