Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs-platform: 7.0.1 -> 7.2.0 #82068

Merged
merged 3 commits into from Mar 14, 2020
Merged

Conversation

@anmonteiro
Copy link
Member

anmonteiro commented Mar 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@anmonteiro anmonteiro force-pushed the anmonteiro:anmonteiro/bs-platform-7.2.0 branch from 9930462 to 7107e39 Mar 8, 2020
@ofborg ofborg bot requested review from gamb and turboMaCk Mar 8, 2020
Copy link
Member

turboMaCk left a comment

  • Tested on NixOS
    just few questions before we go ahead with merge.
BS_RELEASE_BUILD = "true";
BS_TRAVIS_CI = "1";

This comment has been minimized.

Copy link
@turboMaCk

turboMaCk Mar 9, 2020

Member

Can you elaborate on why we need this?

This comment has been minimized.

Copy link
@anmonteiro

anmonteiro Mar 9, 2020

Author Member

For some reason (cf BuckleScript/bucklescript#4183) BuckleScript added yet another idiosyncrasy to its build / release process. This environment variable allows the intermediate artifacts of the stdlib to be built so that editor auto completion works, for example.

This comment has been minimized.

Copy link
@turboMaCk

turboMaCk Mar 9, 2020

Member

Thanks for explanation! I would probably add some short comment about this as it's really non obvious from code itself. Thanks

cp bsconfig.json package.json $out
ln -s $out/lib/bsb $out/bin/bsb
ln -s $out/lib/bsc $out/bin/bsc
ln -s $out/lib/bsrefmt $out/bin/bsrefmt

This comment has been minimized.

Copy link
@turboMaCk

turboMaCk Mar 9, 2020

Member

bsrefmt is gone?

This comment has been minimized.

Copy link
@anmonteiro

anmonteiro Mar 9, 2020

Author Member

This is probably an oversight. I’ll check soon!

anmonteiro added 2 commits Mar 9, 2020
needed
@anmonteiro

This comment has been minimized.

Copy link
Member Author

anmonteiro commented Mar 9, 2020

@turboMaCk addressed your code review.

@ofborg ofborg bot requested a review from turboMaCk Mar 9, 2020
Copy link
Member

turboMaCk left a comment

Looks great to me!

@turboMaCk turboMaCk mentioned this pull request Mar 10, 2020
@gamb
gamb approved these changes Mar 10, 2020
Copy link
Member

gamb left a comment

Thanks for this. Built on MacOS too 👍

@anmonteiro

This comment has been minimized.

Copy link
Member Author

anmonteiro commented Mar 12, 2020

@jonringer could I request a merge from you?

@marsam marsam merged commit 8a0c1b8 into NixOS:master Mar 14, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bs-platform on aarch64-linux Success
Details
bs-platform on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Mar 14, 2020

Thanks!

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Mar 16, 2020

sorry, haven't had as much free time lately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.