Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiProlog: openssl 1.0.2 -> openssl 1.1 #82081

Merged
merged 1 commit into from Mar 17, 2020
Merged

Conversation

@kquick
Copy link
Contributor

kquick commented Mar 9, 2020

Motivation for this change

swiProlog is currently configured to use the deprecated OpenSSL 1.0.2 version. The swiProlog upstream has supported OpenSSL 1.1 since mid-2017; this patch updates the nix specification.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@vcunat vcunat requested a review from meditans Mar 9, 2020
@vcunat
Copy link
Member

vcunat commented Mar 9, 2020

Let's test builds, including darwin.
@GrahamcOfBorg build swiProlog swiPrologWithGui

@vcunat
Copy link
Member

vcunat commented Mar 9, 2020

Hmm, the aarch64 problem when building docs might be just not handling too large make-parallelism well. We do have at least one recent successful build: https://hydra.nixos.org/build/112550303

@kquick
Copy link
Contributor Author

kquick commented Mar 17, 2020

@marsam: I updated the PR, and @vcunat indicates the failing test is probably just a parallelism issue on the builder. I think this is ready for merging to master.

@marsam marsam force-pushed the kquick:swiprolog_openssl_1_1 branch from 3630421 to 2b04225 Mar 17, 2020
@marsam marsam merged commit ffad9c7 into NixOS:master Mar 17, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
swiProlog on aarch64-linux Success
Details
swiProlog on x86_64-linux Success
Details
@kquick kquick deleted the kquick:swiprolog_openssl_1_1 branch Mar 17, 2020
vcunat added a commit that referenced this pull request Mar 24, 2020
(cherry picked from commit ffad9c7)
This is unbreaking the package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.