Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: 2020-02-06 -> 2020-03-04 #82176

Closed
wants to merge 1 commit into from
Closed

hydra: 2020-02-06 -> 2020-03-04 #82176

wants to merge 1 commit into from

Conversation

@Ma27
Copy link
Member

Ma27 commented Mar 9, 2020

Motivation for this change

⚠️ I only tested the migration in a local setup and not yet on my Hydra instance.

Updates Hydra to the latest master (and flake) revision to incorporate the massive performance improvements.

Before this is mergable, the following things should be discussed:

  • I had to split the sources for several hydra variants (a.k.a. flake-support, unstable and stable), however hydra-stable is currently broken since Hydra doesn't compile with nix 2.3. For now, I marked it as broken (since upstream uses pkgs.nixFlakes on Hydra), however we could fix it:
    • Pin Hydra with nix-stable to an older revision (and risking that it lacks appropriate maintenance).
    • Patch Hydra to support Nix 2.3 again (I actually attempted to do this today but this requires a bit more effort).
  • A few weeks ago I was asked if this should be backported to 20.03. I think that it should since Graham provided pretty useful migration instructions and I played around with it locally and the migration feels pretty smooth. However that's up to our release managers.
  • (out of scope) We should consider marking this package as deprecated for 20.09 or 21.03 (depending on when flakes will be stabilized) as there's no point in maintaining this package (in addition to the Nix expressions in nixos/hydra) as soon as flakes are out.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ma27

This comment has been minimized.

Copy link
Member Author

Ma27 commented Mar 26, 2020

Closing for now. @grahamc and I discussed an even better solution in #nixos-dev (https://logs.nix.samueldr.com/nixos-dev/2020-03-24#3218433;) which I'll implement tomorrow :)

@Ma27 Ma27 closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.