Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afew: 2.0.0 -> 3.0.0 #82206

Merged
merged 1 commit into from May 5, 2020
Merged

afew: 2.0.0 -> 3.0.0 #82206

merged 1 commit into from May 5, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented Mar 10, 2020

MailMover: many fixes

Previously, MailMover didn't properly preserve flags when renaming files, and
moved all mail to cur. This was fixed. Also, MailMover gained a test suite.

New filters: PropagateTags[ByRegex]InThreadFilter

These filters allow propagating tags set to a message to the whole thread.

New command line argument: --notmuch-args= in move mode

In move mode, afew calls notmuch new after moving mails around. This
prevents afew -m from being used in a pre-new hook in notmuch.

Now it's possible to specify notmuch args, so something like afew -m --notmuch-args=--no-hooks can live happily in a pre-new hook.

Python 3.4 and 3.5 support dropped

afew stopped supporting the older python versions 3.4 and 3.5, and removed
some more Python 2 compatibility code. (from __future__ import …, utf-8
headers, relative imports, …)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
MailMover: many fixes

  Previously, MailMover didn't properly preserve flags when renaming files, and
  moved all mail to `cur`. This was fixed. Also, MailMover gained a test suite.

New filters: PropagateTags[ByRegex]InThreadFilter

  These filters allow propagating tags set to a message to the whole thread.

New command line argument: --notmuch-args= in move mode

  In move mode, afew calls `notmuch new` after moving mails around. This
  prevents `afew -m` from being used in a pre-new hook in `notmuch`.

  Now it's possible to specify notmuch args, so something like `afew -m
  --notmuch-args=--no-hooks` can live happily in a pre-new hook.

Python 3.4 and 3.5 support dropped

  afew stopped supporting the older python versions 3.4 and 3.5, and removed
  some more Python 2 compatibility code. (`from __future__ import …`, utf-8
  headers, relative imports, …)
@flokli flokli requested a review from FRidh Mar 10, 2020
@ofborg ofborg bot requested a review from andir Mar 10, 2020
@andir andir merged commit 6ca94ab into NixOS:master May 5, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
afew on aarch64-linux Success
Details
afew on x86_64-darwin Success
Details
afew on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.