Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appimageTools: clean appimage-exec.sh options #82266

Closed
wants to merge 2 commits into from

Conversation

@bignaux
Copy link
Contributor

@bignaux bignaux commented Mar 10, 2020

Motivation for this change

As promise, i follow @tilpner review on #81833 .
I also simplify the script removing -w option and fix arguments passing that was missing when using the appimage in a wrapAppImage (i missed to test this use case).
I've integrate #60381 idea since no activity there, test it with minetime, zulip ... seems good.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92

@@ -4,11 +4,15 @@
, lib, runCommand }:

rec {
appimage-exec = pkgs.substituteAll {
appimage-exec = with pkgs; substituteAll {
Copy link
Member

@zimbatm zimbatm Apr 7, 2020

Suggested change
appimage-exec = with pkgs; substituteAll {
appimage-exec = substituteAll {

It's best to be explicit about the dependencies and add it to the function parameters instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants