Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-boot-cli: 2.1.9->2.2.6 #82628

Merged
merged 1 commit into from May 1, 2020
Merged

spring-boot-cli: 2.1.9->2.2.6 #82628

merged 1 commit into from May 1, 2020

Conversation

@moaxcp
Copy link
Contributor

moaxcp commented Mar 15, 2020

Motivation for this change

rename package to match repology.org and update version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

rnhmjoj left a comment

You renamed a package: please add an alias to avoid making this a breaking change.
Aliases are defined inpkgs/top-level/aliases.nix and have a comment of the date when added.

@moaxcp moaxcp force-pushed the moaxcp:spring-boot-cli branch from 7b8dd9c to 783a25b Apr 25, 2020
@moaxcp
Copy link
Contributor Author

moaxcp commented Apr 25, 2020

The alias is added. The purpose is to match the package names in repology.

@moaxcp moaxcp force-pushed the moaxcp:spring-boot-cli branch from 783a25b to c808b46 Apr 25, 2020
Copy link
Contributor

rnhmjoj left a comment

Thank you.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 25, 2020

Can you do a rebase? There is a conflict apparently.

@moaxcp moaxcp force-pushed the moaxcp:spring-boot-cli branch from c808b46 to 4f6226a May 1, 2020
@moaxcp moaxcp force-pushed the moaxcp:spring-boot-cli branch from 4f6226a to 21821de May 1, 2020
@moaxcp moaxcp changed the title spring-boot-cli: 2.1.9->2.2.5 spring-boot-cli: 2.1.9->2.2.6 May 1, 2020
@moaxcp
Copy link
Contributor Author

moaxcp commented May 1, 2020

Ok I think this is fixed now. I also fixed pname and the PATH so it has the other dependencies.

@rnhmjoj
rnhmjoj approved these changes May 1, 2020
Copy link
Contributor

rnhmjoj left a comment

Looks good, thank you.

@rnhmjoj rnhmjoj merged commit d444979 into NixOS:master May 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21821de"; rev="21821de828bc1e8af653930c43700da29d7399f9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21821de"; rev="21821de828bc1e8af653930c43700da29d7399f9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21821de"; rev="21821de828bc1e8af653930c43700da29d7399f9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21821de"; rev="21821de828bc1e8af653930c43700da29d7399f9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21821de"; rev="21821de828bc1e8af653930c43700da29d7399f9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21821de"; rev="21821de828bc1e8af653930c43700da29d7399f9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="21821de"; rev="21821de828bc1e8af653930c43700da29d7399f9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
spring-boot-cli, spring-boot-cli.passthru.tests on aarch64-linux Success
Details
spring-boot-cli, spring-boot-cli.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.