Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomcat-native: init at 1.2.23 #82762

merged 1 commit into from Apr 26, 2020

tomcat-native: init at 1.2.23 #82762

merged 1 commit into from Apr 26, 2020


Copy link

@aanderse aanderse commented Mar 17, 2020

Motivation for this change

Briefly tested with a variant of services.tomcat.javaOpts = [ "-Djava.library.path=${pkgs.tomcat-native}/lib" ];

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

cc @pvgoran in case interested 🤷‍♂️

@aanderse aanderse merged commit 92d9d07 into NixOS:master Apr 26, 2020
17 checks passed
@aanderse aanderse deleted the tomcat-native branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant