Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wine update #82764

Merged
merged 3 commits into from Mar 30, 2020
Merged

Wine update #82764

merged 3 commits into from Mar 30, 2020

Conversation

@avnik
Copy link
Contributor

avnik commented Mar 17, 2020

Motivation for this change

Regular wine unstable+staging update.
combined win64+win32 build (wow) tested -- my usual set of games works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ikervagyok
Copy link
Contributor

ikervagyok commented Mar 29, 2020

Since wine updates take forever on NixOS to land, can you update this PR to 5.5? And of course thanks for the update to 5.4.
https://www.winehq.org/pipermail/wine-devel/2020-March/163220.html

@avnik
Copy link
Contributor Author

avnik commented Mar 29, 2020

@ikervagyok will be 5.5 soon. I just built it, and will update PR after some testing

@avnik
Copy link
Contributor Author

avnik commented Mar 29, 2020

@ikervagyok for first glance 5.5 is brownbag, so stay with 5.4 if you need update fast

@avnik
Copy link
Contributor Author

avnik commented Mar 29, 2020

Well 5.5 is here
@ikervagyok I withdraw my notice about brownbag

Existing prefixes may need to invoke wine64 wineboot.exe -u to upgrade properly.

@ikervagyok
Copy link
Contributor

ikervagyok commented Mar 29, 2020

@avnik thank you

@veprbl
veprbl approved these changes Mar 30, 2020
Copy link
Member

veprbl left a comment

nixpkgs-review report on NixOS (x86_64-linux):

9 package built:
lutris lutris-free lutris-unwrapped pipelight wine-staging winePackages.staging winePackages.unstable wineWowPackages.staging wineWowPackages.unstable
@veprbl veprbl merged commit 296f7e6 into NixOS:master Mar 30, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Mar 31, 2020
Wine update

(cherry picked from commit 296f7e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.