Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] haskellPackages.binary-strict: 0.4.8.4 -> 0.4.8.5 #82780

Merged

Conversation

@erictapen
Copy link
Member

@erictapen erictapen commented Mar 17, 2020

Motivation for this change

I want to use webify on nixos-20.03.

Things done

I basically backported the bump that happened in ea1aae1.

This fixes the build, also of

  • eths-rlp
  • vorbiscomment
  • webify

which depend on binary-strict. Everything else that depends on binary-strict remains broken, so this commit shouldn't break anything that wasn't broken yet.

I know that I edit hackage-packages.nix, which shouldn't be touched by hand. But I'd still propose this, as

  • this doesn't break anything (at least on x86_64-linux)
  • If hackage-packages ever gets regenerated, it will include the bump anyway.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This fixes the build, also of

- eths-rlp
- vorbiscomment
- webify

which depend on binary-strict. Everything else that depends on
binary-strict remains broken, so this commit shouldn't break anything
that wasn't broken yet.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Mar 18, 2020

@GrahamcOfBorg build haskellPackages.binary-strict

@GrahamcOfBorg build haskellPackages.eths-rlp

@GrahamcOfBorg build haskellPackages.vorbiscomment

@GrahamcOfBorg build haskellPackages.webify

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Mar 18, 2020

I know that I edit hackage-packages.nix, which shouldn't be touched by hand. But I'd still propose this, as

Actually, on the release branches we are generally fine with editing the hackage-packages.nix file by hand, since we aren't running hackage2nix automatically.

So this PR should be fine.

@cdepillabout cdepillabout merged commit e2dfbcd into NixOS:release-20.03 Mar 18, 2020
21 of 25 checks passed
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Apr 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/backporting-haskellpackages/6814/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants