Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/phpfpm: add example to socket #82784

Merged
merged 1 commit into from Mar 29, 2020
Merged

nixos/phpfpm: add example to socket #82784

merged 1 commit into from Mar 29, 2020

Conversation

@davidak
Copy link
Member

@davidak davidak commented Mar 17, 2020

Motivation for this change

Fixes #81908

This is how it looks in the manual:
Screenshot from 2020-03-17 15-22-36

Just took me 70 minutes 馃槵

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@aanderse aanderse left a comment

Thanks!

@aanderse aanderse merged commit 24d456a into NixOS:master Mar 29, 2020
13 checks passed
@davidak davidak deleted the fpm branch Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants