Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripcord: make version overriding easier by allowing version and hash … #82799

Closed
wants to merge 1 commit into from

Conversation

@bqv
Copy link
Contributor

bqv commented Mar 17, 2020

…overrides

Motivation for this change

Tried to override to version 0.4.24 before the PR was merged, failed due to ${src} in installPhase, and was a pain anyway due to sha256 being nested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

src = let
appimage = fetchurl {
url = "https://cancel.fm/dl/Ripcord-${version}-x86_64.AppImage";
sha256 = "0rscmnwxvbdl0vfx1pz7x5gxs9qsjk905zmcad4f330j5l5m227z";
sha256 = "${imageHash}";

This comment has been minimized.

Copy link
@Infinisil

Infinisil Mar 18, 2020

Member

This doesn't do what you expect it to. Overriding both version and imageHash will still result in it using the old source

This comment has been minimized.

Copy link
@bqv

bqv Mar 18, 2020

Author Contributor

oh, gotcha. How best then?

This comment has been minimized.

Copy link
@grahamc

grahamc Mar 18, 2020

Member

override the src entirely

This comment has been minimized.

Copy link
@bqv

bqv Mar 18, 2020

Author Contributor

Figures. I'll scratch this then.

@bqv bqv closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.