Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fail2ban: add warning if work fail2ban without firewall #82801

Merged
merged 1 commit into from Mar 22, 2020

Conversation

@Izorkin
Copy link
Contributor

Izorkin commented Mar 17, 2020

Motivation for this change

Fixed this issue - #41422

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 17, 2020

@CRTified
Copy link
Contributor

CRTified commented Mar 17, 2020

In my opinion, #41422 is already fixed by PR #67931, and this assertion is not required anymore.

It is probably a rare use-case to use fail2ban without iptables (and thus in turn without networking.firewall), e.g. for plain logging purposes or with other actions like nftables-allports, shorewall or cloudflare (which are all alternative firewalls/approaches), but merging this PR would prohibit these usecases.

In my opinion, it would make more sense as a warning or info, e.g. with lib.warn. That way, uses who do not know about this interaction are warned, while the warning/info can be ignored when everything is fine.

@Izorkin Izorkin force-pushed the Izorkin:fail2ban branch from 86dc195 to c75398b Mar 18, 2020
@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 18, 2020

Changed to warning

@Izorkin Izorkin changed the title nixos/fail2ban: disable work fail2ban without firewall nixos/fail2ban: add warning if work fail2ban without firewall Mar 18, 2020
@CRTified
Copy link
Contributor

CRTified commented Mar 18, 2020

In my opinion, it looks ready to merge.

Only minor wish would be to use lib.any in the condition, as that is a bit more flexible in the future (as it allows adding other possibilities with less boilerplate).

@Mic92 Mic92 merged commit 2edf67b into NixOS:master Mar 22, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Izorkin Izorkin deleted the Izorkin:fail2ban branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.