Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-browser-bundle-bin: enable multimedia support by default #82807

Merged
merged 1 commit into from Mar 29, 2020

Conversation

@mehlon
Copy link
Contributor

mehlon commented Mar 17, 2020

Motivation for this change

Fixes #82597
Fixes #82594

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@alyssais
Copy link
Member

alyssais commented Mar 18, 2020

Check the impact on closure size please.

@mehlon
Copy link
Contributor Author

mehlon commented Mar 18, 2020

nix path-info -S closure size:
Before:
/nix/store/igl0s3kbwbw4qsli2ddddhchh358mjw3-tor-browser-bundle-bin-9.0.6 635461480
After:
/nix/store/5lkqlc017p58vnjvm34vk78zkzwkwkzc-tor-browser-bundle-bin-9.0.6 696314464

@Ma27
Ma27 approved these changes Mar 20, 2020
Copy link
Member

Ma27 left a comment

The closure size impact seems justifiable for a GUI application IMHO. What do you think @alyssais? :)

@mehlon
Copy link
Contributor Author

mehlon commented Mar 21, 2020

It appears this version has a bug. When the Tor Browser starts, some add-ons might be disabled, including NoScript. To replicate: set the security level to "Safest" (which disables Javascript) then check https://enable-javascript.com/ which says whether Javascript is enabled.
Try this with both the version before and after enabling multimedia.
This needs to be investigated before merging. It might even be a problem upstream.

@mehlon
Copy link
Contributor Author

mehlon commented Mar 21, 2020

Actually, it seems to have been introduced in 9.0.6, not this pull request #83096
That means this pull request is still ready to merge.

@alyssais
Copy link
Member

alyssais commented Mar 22, 2020

The closure size impact seems justifiable for a GUI application IMHO. What do you think @alyssais? :)

Agreed.

@flokli flokli merged commit ae39289 into NixOS:master Mar 29, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mehlon mehlon deleted the mehlon:tor-browser branch Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.