Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.vim-pandoc: fix startup #82810

Merged
merged 1 commit into from Mar 17, 2020
Merged

vimPlugins.vim-pandoc: fix startup #82810

merged 1 commit into from Mar 17, 2020

Conversation

@timokau
Copy link
Member

@timokau timokau commented Mar 17, 2020

Motivation for this change

vim-pandoc fails on startup, which breaks building my neovim configuration.

This will cause some pain on the next package set update (since the patch will fail to apply), but I don't know how we could handle this better. I'll keep an eye on (and subscribed to) the upstream issue and remove the patch when possible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@timokau timokau requested a review from jonringer as a code owner Mar 17, 2020
@timokau timokau merged commit c8a67fd into NixOS:master Mar 17, 2020
16 checks passed
@timokau timokau deleted the vim-pandoc-fix branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant