Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] python: add pythonNamespacesHook #82813

Merged
merged 3 commits into from Mar 18, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 17, 2020

Motivation for this change

closes #82756

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer requested a review from FRidh as a code owner Mar 17, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Mar 17, 2020

@GrahamcOfBorg build azure-cli

@jonringer jonringer force-pushed the python-namespace-hook branch from 822a6ac to ff4e49e Mar 17, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Mar 17, 2020

@GrahamcOfBorg build azure-cli

FRidh
FRidh approved these changes Mar 18, 2020
@jonringer jonringer merged commit cf0f90b into NixOS:staging Mar 18, 2020
19 checks passed
@jonringer jonringer deleted the python-namespace-hook branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants