Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weechat-notify-send: init at 0.9 #82814

Merged
merged 1 commit into from Aug 24, 2020
Merged

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Mar 17, 2020

Motivation for this change

Send desktop notifications from weechat via libnotify.

https://github.com/s3rvac/weechat-notify-send

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tobim tobim changed the title weechat-notify-send: init at 0.8 weechat-notify-send: init at 0.9 Mar 17, 2020
@tobim tobim force-pushed the init/weechat-notify-send branch from 8cc2da1 to 8dad5f3 Mar 17, 2020
@Ma27 Ma27 requested a review from jonringer Mar 20, 2020
Ma27
Ma27 approved these changes Mar 20, 2020
@@ -55,7 +55,7 @@
<programlisting>weechat.override {
configure = { availablePlugins, ... }: {
scripts = with pkgs.weechatScripts; [
weechat-xmpp weechat-matrix-bridge wee-slack
weechat-xmpp weechat-matrix-bridge wee-slack weechat-notify-send
Copy link
Member

@alyssais alyssais Aug 16, 2020

I don’t think we need to list every weechat plugin in this example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants