Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.rope: 0.14.0 -> 0.16.0 #83019

Merged
merged 1 commit into from Mar 26, 2020
Merged

Conversation

@bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 20, 2020

Motivation for this change

Note: rope is broken with Python 3.8; I have disabled it until its next release in a separate PR (#83009).

nixpkgs-review builds all Python 3.7 packages correctly but of course all Python 3.8 fails as well as previously broken package python27Packages.python-language-server and its reverse dep python27Packages.pyls-isort.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Mar 24, 2020

Can you amend to add double-quotes (i.e. "") around the homepage?

@bcdarwin bcdarwin force-pushed the bcdarwin:update-python-rope branch from bb23ec6 to 8e131cd Mar 24, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:update-python-rope branch from 8e131cd to c1c91ea Mar 24, 2020
@bcdarwin
Copy link
Member Author

@bcdarwin bcdarwin commented Mar 24, 2020

@drewrisinger -- done, and I've re-run nixpkgs-review on a rebase onto master.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Diff looks good.
Builds locally with nixpkgs-review.

[15 built, 432 copied (2233.8 MiB), 447.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83019
12 package built:
cq-editor nixpkgs-pytools python27Packages.pyls-isort python27Packages.python-language-server python27Packages.rope python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python37Packages.rope spyder python37Packages.spyder_3
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

https://github.com/NixOS/nixpkgs/pull/83019
12 package built:
cq-editor nixpkgs-pytools python27Packages.pyls-isort python27Packages.python-language-server python27Packages.rope python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python37Packages.rope spyder python37Packages.spyder_3
@jonringer jonringer merged commit 5df826f into NixOS:master Mar 26, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bcdarwin bcdarwin deleted the bcdarwin:update-python-rope branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.