Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo edit: 0.5.0 -> 0.6.0 #83070

Merged
merged 1 commit into from Mar 26, 2020
Merged

cargo edit: 0.5.0 -> 0.6.0 #83070

merged 1 commit into from Mar 26, 2020

Conversation

@killercup
Copy link
Member

killercup commented Mar 21, 2020

Motivation for this change

New release: https://github.com/killercup/cargo-edit/releases/tag/v0.6.0

Additional changes:

  • Add myself as maintainer
  • Some workspace test failed with a cargo config error, I didn't investigate too much. This was a problem in earlier versions, too.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@killercup killercup force-pushed the killercup:cargo-edit-0.6.0 branch from f4b2aee to 00a9db2 Mar 21, 2020
@killercup killercup force-pushed the killercup:cargo-edit-0.6.0 branch from 00a9db2 to b1f8634 Mar 21, 2020
Copy link
Contributor

bhipple left a comment

LGTM, commits should be squashed up prior to merge tho!

pkgs/tools/package-management/cargo-edit/default.nix Outdated Show resolved Hide resolved
@killercup killercup force-pushed the killercup:cargo-edit-0.6.0 branch from b1f8634 to 0de9219 Mar 22, 2020
- Update to new version
- Add myself as maintainer
- Some workspace test failed with a cargo config error, I didn't
  investigate too much.
- Add Apache 2.0 license
@killercup killercup force-pushed the killercup:cargo-edit-0.6.0 branch from 0de9219 to 84ac1d5 Mar 22, 2020
@killercup

This comment has been minimized.

Copy link
Member Author

killercup commented Mar 25, 2020

ping @bhipple should be good to merge

@bhipple

This comment has been minimized.

Copy link
Contributor

bhipple commented Mar 26, 2020

[4 built, 0.0 MiB DL]
1 package built:
cargo-edit
@bhipple bhipple merged commit 7f62b75 into NixOS:master Mar 26, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.