Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

znapzend: 0.18.0 -> 0.20.0 #83257

Merged
merged 2 commits into from May 5, 2020
Merged

znapzend: 0.18.0 -> 0.20.0 #83257

merged 2 commits into from May 5, 2020

Conversation

@rail
Copy link
Contributor

rail commented Mar 24, 2020

Motivation for this change
  • update to latest znapzend version which supports sendRaw features (encrypted backups)
Things done

I tested this on "my laptop" ™️ :) I use native ZFS encryption and with sendRaw feature enabled I get properly generated backups that I can mount only by specifying the encryption passphrase.

Is there any other scenario that I should use to test this?

This is my configuration.nix snippet:

  services.znapzend = {
    enable = true;
    autoCreation = true;
    pure = true;
    features.sendRaw = true;
    zetup = {
      "rpool/HOME" = {
        plan = "4hour=>15min,2day=>1hour,7day=>1day,3week=>1week";
        enable = true;
        destinations = {
          local = {
            dataset = "backup/HOME";
            plan = "4hour=>15min,4day=>1hour,1week=>1day,1year=>1week,10year=>1month";
          };
        };
      };
      "rpool/NIXOS" = {
        plan = "1day=>1hour,7day=>1day,3week=>1week";
        enable = true;
        destinations = {
          local = {
            dataset = "backup/NIXOS";
            plan = "4days=>1hour,1week=>1day,1year=>1week,10year=>1month";
          };
        };
      };
    };
  };
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
rail added 2 commits Mar 23, 2020
* Update znapzend and the dependencies
* add autoreconfHook
@rail
Copy link
Contributor Author

rail commented Mar 24, 2020

@Infinisil, I see you added the futures option recently. You may be also interested in this change. ;)

@rail
Copy link
Contributor Author

rail commented May 5, 2020

Let's try the next person in the commit log, @fpletz :) Maybe you have some time to review this.

@Mic92 Mic92 merged commit ff0da3a into NixOS:master May 5, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
znapzend on aarch64-linux Success
Details
znapzend on x86_64-linux Success
Details
@Mic92
Copy link
Contributor

Mic92 commented May 5, 2020

Thanks!

@rail
Copy link
Contributor Author

rail commented May 5, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.