New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gn: 20190403 -> 2020-03-09 #83290
gn: 20190403 -> 2020-03-09 #83290
Conversation
This updates gn to the required version for chromiumDev (the recommended version for the stable release of Chromium isn't sufficient [0]). [0]: The Chromium build fails during the configuration phase: ERROR at //mojo/public/tools/bindings/mojom.gni:393:16: Undefined identifier "cpp_typemaps", ^-------------
With NixOS#83290 merged the build would fail during the configuration phase: ``` configuring ERROR at //gn/BUILDCONFIG.gn:85:14: Script returned non-zero exit code. is_clang = exec_script("gn/is_clang.py", ^---------- Current dir: /build/source/out/Release/ Command: python /build/source/gn/gn/is_clang.py cc c++ Returned 2. stderr: python: can't open file '/build/source/gn/gn/is_clang.py': [Errno 2] No such file or directory ```
I did some additional manual testing and fixed one regression. Assuming I didn't miss anything with my minimal testing approach, the rest of the rebuilds should be fine. |
@NixOS/backports I just realized that I'll need this change on |
With NixOS#83290 merged the build would fail during the configuration phase: ``` configuring ERROR at //gn/BUILDCONFIG.gn:85:14: Script returned non-zero exit code. is_clang = exec_script("gn/is_clang.py", ^---------- Current dir: /build/source/out/Release/ Command: python /build/source/gn/gn/is_clang.py cc c++ Returned 2. stderr: python: can't open file '/build/source/gn/gn/is_clang.py': [Errno 2] No such file or directory ``` (cherry picked from commit ad66bbd)
I don't necessarily disagree (would e.g. be easier to maintain), but why does this apply to Chromium specifically? There aren't any tagged releases for
Did this PR break anything?
This is currently the case due to breaking gn changes. We therefore simply override gn for the beta and dev channels. |
I've opened #85457 to further track this discussion (as this PR is already merged) ;) |
With NixOS#83290 merged the build would fail during the configuration phase: ``` configuring ERROR at //gn/BUILDCONFIG.gn:85:14: Script returned non-zero exit code. is_clang = exec_script("gn/is_clang.py", ^---------- Current dir: /build/source/out/Release/ Command: python /build/source/gn/gn/is_clang.py cc c++ Returned 2. stderr: python: can't open file '/build/source/gn/gn/is_clang.py': [Errno 2] No such file or directory ``` (cherry picked from commit ad66bbd)
This updates gn to the required version for chromiumDev (the recommended
version for the stable release of Chromium isn't sufficient [0]).
[0]: The Chromium build fails during the configuration phase:
ERROR at //mojo/public/tools/bindings/mojom.gni:393:16: Undefined identifier
"cpp_typemaps",
^-------------
Testing
I only verified it with the configuration phase of
chromium
andchromiumDev
(which both work),e.g.:Update: I've verified additional configuration phases:
v8
qt5.qtwebengine
aseprite.skia
Motivation
This fixes the build of
chromiumDev
and is possibly required for other builds too (or will be soon).I've also added some extra notes and did a minor refactoring.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc maintainers: @stesie @matthewbauer