Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixiecore: init at 2020-03-25 #83373

Merged
merged 1 commit into from Mar 26, 2020
Merged

pixiecore: init at 2020-03-25 #83373

merged 1 commit into from Mar 26, 2020

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Mar 25, 2020

Motivation for this change

This is a rebase of #62113 (without the module, I'll do that next). I added the other contributor as a Co-authored-by.

package and module requested in #49740

Note that according to https://github.com/danderson/netboot the project is "no longer actively developed". But it still works fine and it's a really useful tool. See https://nixos.wiki/wiki/Netboot

@Lassulus @aanderse @Ekleog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Mar 25, 2020

You are right @Valodim . Thanks! I made the change.

@Valodim
Copy link
Contributor

@Valodim Valodim commented Mar 25, 2020

you'll still have to point the repo attribute to netboot :)

@bbigras bbigras force-pushed the bbigras:pixiecore branch from 6ebecf5 to 44e0aa7 Mar 26, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Mar 26, 2020

Right, sorry.

@bbigras bbigras mentioned this pull request Mar 26, 2020
3 of 10 tasks complete
Co-authored-by: raunovv <rauno@oyenetwork.com>
@bbigras bbigras force-pushed the bbigras:pixiecore branch from 44e0aa7 to 78fbe7d Mar 26, 2020
@ofborg ofborg bot requested a review from danderson Mar 26, 2020
@Mic92 Mic92 merged commit 461784f into NixOS:master Mar 26, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pixiecore on aarch64-linux Success
Details
pixiecore on x86_64-linux Success
Details
@bbigras bbigras deleted the bbigras:pixiecore branch Mar 26, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Mar 26, 2020

Thanks!

@Mic92 Mic92 mentioned this pull request Apr 2, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.