Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malcontent: 0.6.0 → 0.7.0 #83400

Merged
merged 4 commits into from Apr 8, 2020
Merged

malcontent: 0.6.0 → 0.7.0 #83400

merged 4 commits into from Apr 8, 2020

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 26, 2020

Motivation for this change

Changes: https://gitlab.freedesktop.org/pwithnall/malcontent/-/commit/2e8a07d58c047f757e36a5fcf1d5b76faae08e75

Allows us to split the UI package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Mar 26, 2020

On staging gnome-initial-setup depends on malcontent-ui so we will need to disable it first. See #83403.

Copy link
Member

@worldofpeace worldofpeace left a comment

I made two minor changes, and I read over https://gitlab.freedesktop.org/pwithnall/malcontent/-/merge_requests/38 and the patches. It sucks we can't get perfect separation.
Installed tests work for me also (though I got a weird unreproducible failure when I first built them).

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Mar 28, 2020

Forgot to mention motivation for enabling accounts-service in the module. It does require it so we should just do it there anyways.

@jtojnar jtojnar force-pushed the jtojnar:malcontent-0.7 branch from 8a57eda to c78114e Apr 1, 2020
@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Apr 1, 2020

@jtojnar jtojnar force-pushed the jtojnar:malcontent-0.7 branch from c78114e to de07d15 Apr 2, 2020
@grahamc
Copy link
Member

@grahamc grahamc commented Apr 2, 2020

@grahamc
Copy link
Member

@grahamc grahamc commented Apr 2, 2020

(note I'm actively debugging this)

@jtojnar jtojnar force-pushed the jtojnar:malcontent-0.7 branch from de07d15 to ddb8b58 Apr 7, 2020
jtojnar and others added 4 commits Mar 26, 2020
The 0.7.0 update allows us to split the package.
Installed tests tried to load the PAM module from installed tests prefix instead of the configured pamlibdir.

Forgot to do this in 0.5.0 bump.
@jtojnar jtojnar force-pushed the jtojnar:malcontent-0.7 branch from ddb8b58 to 309fed2 Apr 8, 2020
@jtojnar jtojnar merged commit 521ddb1 into NixOS:master Apr 8, 2020
17 checks passed
17 checks passed
malcontent, malcontent-ui, malcontent-ui.passthru.tests, malcontent.passthru.tests on x86_64-darwin No attempt
Details
malcontent, malcontent-ui, malcontent-ui.passthru.tests, malcontent.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="309fed2"; rev="309fed2b2f3b6967f63c008b0c6cc81fc2e97e84"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="309fed2"; rev="309fed2b2f3b6967f63c008b0c6cc81fc2e97e84"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="309fed2"; rev="309fed2b2f3b6967f63c008b0c6cc81fc2e97e84"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="309fed2"; rev="309fed2b2f3b6967f63c008b0c6cc81fc2e97e84"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="309fed2"; rev="309fed2b2f3b6967f63c008b0c6cc81fc2e97e84"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="309fed2"; rev="309fed2b2f3b6967f63c008b0c6cc81fc2e97e84"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="309fed2"; rev="309fed2b2f3b6967f63c008b0c6cc81fc2e97e84"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
malcontent, malcontent-ui, malcontent-ui.passthru.tests, malcontent.passthru.tests on aarch64-linux Success
Details
@jtojnar jtojnar deleted the jtojnar:malcontent-0.7 branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.