Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.gnuplot: 0.5.3 → 0.7 #83402

Merged
merged 3 commits into from Apr 1, 2020
Merged

ocamlPackages.gnuplot: 0.5.3 → 0.7 #83402

merged 3 commits into from Apr 1, 2020

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 26, 2020

Motivation for this change

Drop dependency of ocaml-gnuplot on the core library.

The phylogenetics package must be updated for compatibility with ocaml-gnuplot (cc @bcdarwin).

Updated phylogenetics depends on ocaml-r, which is thus packaged in this PR too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Mar 26, 2020

@GrahamcOfBorg build ocamlPackages.ocaml-r ocamlPackages.gnuplot ocamlPackages.phylogenetics

description = "OCaml bindings for the R interpreter";
inherit (src.meta) homepage;
license = lib.licenses.gpl3;
};

This comment has been minimized.

@bcdarwin

bcdarwin Mar 26, 2020
Member

Feel free to add me as maintainer if you want.

This comment has been minimized.

@vbgl

vbgl Mar 26, 2020
Author Contributor

Thanks a lot!

};

preConfigure = ''
substituteInPlace stubgen/stubgen.ml --replace 'failwithf "not supported: %s" name ()' 'sprintf "(* not supported: %s *)" name'

This comment has been minimized.

@bcdarwin

bcdarwin Mar 26, 2020
Member

nit: this line is too long

This comment has been minimized.

@vbgl

vbgl Mar 26, 2020
Author Contributor

I’ve split the line and added a comment to justify it. Maybe worth reporting the issue upstream.

@vbgl vbgl force-pushed the vbgl:ocaml-gnuplot-0.7 branch from 1b57d04 to fc004a5 Mar 26, 2020
vbgl added 3 commits Mar 26, 2020
@vbgl vbgl force-pushed the vbgl:ocaml-gnuplot-0.7 branch from fc004a5 to 3a393d6 Mar 26, 2020
@vbgl vbgl merged commit 34db9b5 into NixOS:master Apr 1, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.gnuplot, ocamlPackages.ocaml-r, ocamlPackages.phylogenetics on aarch64-linux Success
Details
ocamlPackages.gnuplot, ocamlPackages.ocaml-r, ocamlPackages.phylogenetics on x86_64-darwin Success
Details
ocamlPackages.gnuplot, ocamlPackages.ocaml-r, ocamlPackages.phylogenetics on x86_64-linux Success
Details
@vbgl vbgl deleted the vbgl:ocaml-gnuplot-0.7 branch Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.