Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME fixes #83403

Merged
merged 3 commits into from Mar 27, 2020
Merged

GNOME fixes #83403

merged 3 commits into from Mar 27, 2020

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 26, 2020

Motivation for this change

Fixing few issues I noticed while using GNOME 3.36.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
jtojnar added 3 commits Mar 26, 2020
This is not tested yet.
Trying to record screen (ctr-alt-shift-r) fails with the following logged:

	Can't create videoconvert element
	shell_recorder_close: assertion 'recorder->state != RECORDER_STATE_CLOSED' failed

videoconvert plug-in is part of gst-plugins-base.
Copy link
Contributor

@hedning hedning left a comment

Looks good to me :) Just noticed that the screen recorder didn't work so good getting that fixed before 3.36 hits unstable.

@jtojnar
Copy link
Contributor Author

@jtojnar jtojnar commented Mar 27, 2020

It is weird, though, since I would expect the base plugins to be propagated by good. Maybe another fallout from the wrapper changes?

@hedning
Copy link
Contributor

@hedning hedning commented Mar 27, 2020

Hmm, looks like «good» doesn't propagate «base», which I guess it probably should. So it looks like we simply lost «base» when removing clutter.

@jtojnar jtojnar merged commit 10c984c into NixOS:staging Mar 27, 2020
16 checks passed
16 checks passed
gnome3.gnome-initial-setup, gnome3.gnome-shell on aarch64-linux Timed out, unknown build status
Details
gnome3.gnome-initial-setup, gnome3.gnome-shell on x86_64-darwin No attempt
Details
gnome3.gnome-initial-setup, gnome3.gnome-shell on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:gnome-fixes branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.