Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost17x: 1.7.1 -> 1.7.2 #83419

Closed
wants to merge 1 commit into from
Closed

boost17x: 1.7.1 -> 1.7.2 #83419

wants to merge 1 commit into from

Conversation

@dasj19
Copy link
Contributor

@dasj19 dasj19 commented Mar 26, 2020

Motivation for this change

Updated boost libraries to its latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    @peti
@bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 27, 2020

@GrahamcOfBorg build rippled

Copy link
Contributor

@bhipple bhipple left a comment

Looks like at least rippled has issues:

                 from /build/source/src/ripple/unity/soci_ripple.cpp:21:
include/boost/coroutine/asymmetric_coroutine.hpp:2388:1: note:   'boost::coroutines::end'
make[2]: *** [CMakeFiles/rippled.dir/build.make:375: CMakeFiles/rippled.dir/src/ripple/unity/soci_ripple.cpp.o] Error 1

Mind taking a look and running nixpkgs-review to see if there are others?

@dasj19
Copy link
Contributor Author

@dasj19 dasj19 commented Mar 29, 2020

Looks like nixpkgs-review is not a package in nix... so I ran nix-review pr 83419
Here are the results:

2 package failed to build:
rippled rippled-validator-keys-tool

3 package built:
boost172 qmediathekview zcash

@bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 29, 2020

Yup that's it; it was renamed a while ago:
https://github.com/Mic92/nixpkgs-review#nixpkgs-review

On the current master of NixPkgs, either attribute works, e.g.

$ nix-build -A nix-review -A nixpkgs-review
/nix/store/9ywlmbslln9va0i2kmbj9gz1bdc40a44-nixpkgs-review-2.2.0
/nix/store/9ywlmbslln9va0i2kmbj9gz1bdc40a44-nixpkgs-review-2.2.0

At any rate, can you check if rippled has an upgrade that we can do?

@dasj19
Copy link
Contributor Author

@dasj19 dasj19 commented Mar 29, 2020

no there is no update for rippled as of this moment. but i noticed that it makes use of boost which translates to boost16x not boost17x which I have added.

Note... I'm trying right now to get it to use boost172

@bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 29, 2020

Inside the package, it just specifies boost, but at the top-level in all-packages.nix, rippled is defined like this:

  rippled = callPackage ../servers/rippled {
    boost = boost17x;
  };

So it is getting updated here :)

Using the unversioned name inside the default.nix allows the caller (distribution / overlay) to easily override the boost that it builds with consistently across the distribution, so pins are generally specified there rather than scattered across the individual files. I'd see if they have a patch upstream for support, and if not change it to boost171 with a comment explaining the error on boost 1.72.

@bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 30, 2020

Looks good; for the 2nd commit, can you amend the subject to:

rippled, rippled-validator-keys-tool: update pinned boost versions

EDIT: Actuall,y now I'm seeing this:

  /build/validator-keys-tool-d7774bc/src/test/ValidatorKeys_test.cpp:288:31: error: 'const class boost::optional<std::vector<unsigned char> >' has no member named 'first'
    288 |             BEAST_EXPECT (ret.first.size ());
        |                               ^~~~~

@GrahamcOfBorg build rippled-validator-keys-tool

@dasj19
Copy link
Contributor Author

@dasj19 dasj19 commented Mar 30, 2020

thanks @bhipple I'm still compiling different versions of rippled-validator-keys-tool to get a clean working build.... can you try a nixpkg-review pr 83419? I may have to stash my local changes to get a clean build

@bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 30, 2020

The above output is from me running just that. BTW, you can run it yourself as well:

nix run -I nixpkgs=channel:nixos-unstable nixpkgs.nixpkgs-review -c nixpkgs-review pr 83419

(There's no special maintainer permission on this; it's just a nix tool like any other.)

@dasj19
Copy link
Contributor Author

@dasj19 dasj19 commented Mar 30, 2020

I get this... but I may say I have a very dirty local nixpkgs repo

uilder for '/nix/store/95k9n64x5h9zwlf8pa56irqvy6syq428-rippled-validator-keys-tool-20180927-d7774bc.drv' failed with exit code 2; last 10 log lines:
  -- Build files have been written to: /build/validator-keys-tool-d7774bc/build
  cmake: enabled parallel building
  building
  build flags: -j8 -l8 SHELL=/nix/store/z4ajipns0l1s8b2lrgpy6nng4cys7h99-bash-4.4-p23/bin/bash
  Scanning dependencies of target validator-keys
  [ 20%] Building CXX object CMakeFiles/validator-keys.dir/src/ValidatorKeys.cpp.o
  make[2]: *** No rule to make target '/nix/store/l30vvmj1qaldlnckkvd04lr5yrpia8ix-boost-1.72.0-dev/lib/libboost_coroutine-mt-x64.so.1.72.0', needed by 'validator-keys'.  Stop.
  make[2]: *** Waiting for unfinished jobs....
  make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/validator-keys.dir/all] Error 2
  make: *** [Makefile:84: all] Error 2
cannot build derivation '/nix/store/l7gphfwmwnjkp1hi1c74mgxs1w0c29pb-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/l7gphfwmwnjkp1hi1c74mgxs1w0c29pb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/83419
1 package failed to build:
rippled-validator-keys-tool

3 package built:
boost172 qmediathekview zcash

@dasj19
Copy link
Contributor Author

@dasj19 dasj19 commented Mar 30, 2020

the bot failed to build as well... I'll see what I can do... now I am in a middle of a huge switch so I have to wait for some compiling work

@dasj19 dasj19 force-pushed the dasj19:boost_update branch from fa4bed5 to 5b9966d Mar 31, 2020
@dasj19
Copy link
Contributor Author

@dasj19 dasj19 commented Mar 31, 2020

I left untouched the rippled-validator-keys-tool package which still uses boost167, the update of that package will be in another PR (although i don't promise anything).

This builds fine for me. let's see what the bot says.

@GrahamcOfBorg build rippled-validator-keys-tool rippled

Edit: It seems it still fails so I have to take care of rippled-validator-keys-tool within this PR. So it is a work in progress...

@bhipple
Copy link
Contributor

@bhipple bhipple commented May 4, 2020

It appears this PR was superseded by #84182

@bhipple bhipple closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.