Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xp-pen-g430: init at 20190820 #83426

Merged
merged 1 commit into from Apr 2, 2020
Merged

xp-pen-g430: init at 20190820 #83426

merged 1 commit into from Apr 2, 2020

Conversation

@IvarWithoutBones
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones commented Mar 26, 2020

Motivation for this change

This is a useful driver package for people with the xp-pen g430 drawing tablet.
Review was done over at #76180

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Apr 2, 2020

Moved maintainers entry to resolve merge conflict & rebased on master.

As a git tip, if you have a list of things that gets updated regularly, try to insert somewhere in the middle (especially if it’s roughly sorted alphabetically). That reduces the chance of merge conflicts dramatically (because if everybody adds at the end, conflicts are pretty much guaranteed).

@ofborg ofborg bot added the 10.rebuild-linux: 1 label Apr 2, 2020
@Profpatsch Profpatsch merged commit 318f05f into NixOS:master Apr 2, 2020
16 checks passed
16 checks passed
xp-pen-g430, xp-pen-g430.passthru.tests on aarch64-linux No attempt
Details
xp-pen-g430, xp-pen-g430.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="436ebaa"; rev="436ebaafa2bdf0d13824a10d6648e1cfead75e64"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="436ebaa"; rev="436ebaafa2bdf0d13824a10d6648e1cfead75e64"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="436ebaa"; rev="436ebaafa2bdf0d13824a10d6648e1cfead75e64"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="436ebaa"; rev="436ebaafa2bdf0d13824a10d6648e1cfead75e64"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="436ebaa"; rev="436ebaafa2bdf0d13824a10d6648e1cfead75e64"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="436ebaa"; rev="436ebaafa2bdf0d13824a10d6648e1cfead75e64"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="436ebaa"; rev="436ebaafa2bdf0d13824a10d6648e1cfead75e64"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@IvarWithoutBones
Copy link
Contributor Author

@IvarWithoutBones IvarWithoutBones commented Apr 2, 2020

Will do in the future, thank you for the feedback 👍

@IvarWithoutBones IvarWithoutBones deleted the IvarWithoutBones:xp-pen branch Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.