Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma-5,kde,kde-frameworks: update #83435

Closed
wants to merge 1 commit into from
Closed

plasma-5,kde,kde-frameworks: update #83435

wants to merge 1 commit into from

Conversation

@bachp
Copy link
Member

@bachp bachp commented Mar 26, 2020

Motivation for this change

This is still work in progress in case somebody else is interested in helping out.

Update Plasma, KDE frameworks and KDE Applications to the newest versions:

  • Plasma: 5.18.3
  • KDE Framworks: 5.68
  • KDE Applications: 19.12.3

This is the first time I'm working with KDE packaging in NixOS so I'm not sure I did it right.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@ttuegel ttuegel left a comment

I don't know what's going on with the patches, but some important fixes were removed.

Because these are three package sets with different release schedules, I would prefer to update them each in a separate pull request.

@@ -13,7 +13,6 @@ mkDerivation {
ki18n kio glib gtk2 gtk3 karchive kcmutils kconfigwidgets kiconthemes
knewstuff gsettings-desktop-schemas
];
patches = [ ./patches/follow-symlinks.patch ./patches/gsettings.patch ];

This comment has been minimized.

@ttuegel

ttuegel Mar 31, 2020
Member

These patches are essential; where did they go?

}
}
sourceFiles(scripts);
-

This comment has been minimized.

@ttuegel

ttuegel Mar 31, 2020
Member

It is important that startkde doesn't contaminate the XDG_DATA_DIRS variable. Why is this removed?

@@ -44,7 +44,7 @@ mkDerivation {

patches = [
./0001-startkde.patch
./0002-absolute-wallpaper-install-dir.patch
# ./0002-absolute-wallpaper-install-dir.patch #TODO(bachp): check if this is needed https://github.com/KDE/plasma-workspace/blob/Plasma/5.18/sddm-theme/theme.conf.cmake

This comment has been minimized.

@ttuegel

ttuegel Mar 31, 2020
Member

This patch is needed to set the correct absolute path to the SDDM theme wallpaper.

@@ -1,2 +1 @@
kcmutils-follow-symlinks.patch
kcmutils-debug-module-loader.patch

This comment has been minimized.

@ttuegel

ttuegel Mar 31, 2020
Member

This patch is important for us to get useful bug reports. Please leave it in place.

This comment has been minimized.

@bachp

bachp Mar 31, 2020
Author Member

If I recall correctly the files this was patching does no longer exists.

This comment has been minimized.

@ttuegel

ttuegel Mar 31, 2020
Member

We need to find out where that code went and apply the patch there. It may even have moved to a different library, unfortunately.

This comment has been minimized.

@bachp

bachp Mar 31, 2020
Author Member

I just tried to get things compiling so we know what to look at. But the patches are not very well documented so it's hared to tell why they are needed.

How is this normaly done?

@FRidh FRidh added this to Needs review in Staging Apr 3, 2020
@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Apr 7, 2020

Superseded by #84542 and #83897

@peterhoeg peterhoeg closed this Apr 7, 2020
Staging automation moved this from Needs review to Done Apr 7, 2020
@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Apr 7, 2020

Just closing this may seem a bit ungrateful - sorry if it seemed that way @bachp.

Thanks for doing this but I suggest you help out on the linked PR instead.

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Apr 7, 2020

Sorry, I didn't see this one before. My result is mostly the same until now, but I am still working on re-adding all the patches.

@bachp
Copy link
Member Author

@bachp bachp commented Apr 7, 2020

@peterhoeg No worries, I'm actually glad somebody more experienced takes over, I can look over their shoulders.

@bachp bachp deleted the bachp:plasma-kde branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.