Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mediawiki: allow using default extensions #83436

Merged
merged 1 commit into from May 1, 2020

Conversation

@mmilata
Copy link
Member

mmilata commented Mar 26, 2020

It appears the MediaWiki module "hides" the extensions that are shipped in the package. Please consider whether this PR improves the module by allowing them to be easily used, or whether it just makes it confusing.

cc @aanderse @redvers

Motivation for this change

Mostly convenience - MediaWiki ships with bunch of extensions and these often require particular MediaWiki version. Using the ones bundled with the wiki source, one does not have to manually update them whenever the wiki is updated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@aanderse
Copy link
Contributor

aanderse commented Apr 6, 2020

@GrahamcOfBorg test mediawiki

Copy link
Contributor

aanderse left a comment

@mmilata one thing I came to regret about the mediawiki module is that extensions and skins are handled in the module, instead of the package. I've recently realized that allowing allowing a mechanism for customizing packages makes for a much stronger module, as opposed to providing those customizations on the package from inside the module.

That being said... the way this module currently is setup, this is a very nice addition and based on the assumption you have properly tested this I approve 👍

It would be nice to get approval from @redvers too, but if he doesn't reply back in a day or two just ping me and I'll merge. Thanks for your work on this 🎉

@mmilata
Copy link
Member Author

mmilata commented Apr 6, 2020

@aanderse can you please elaborate, or point to an example of such package? I'm struggling to imagine how this works and would like to write better modules too:)

Also, I'm wondering whether this PR should use true instead of null as that would result in slightly more self-descriptive configuration.

@aanderse
Copy link
Contributor

aanderse commented Apr 6, 2020

@mmilata anything with plugins that uses symlinkJoin is probably a good example. I'll circle back to this when I have some time.

@aanderse
Copy link
Contributor

aanderse commented May 1, 2020

@mmilata unfortunately this hasn't hit the top of my priority list yet. I also forgot to come back and merge this... sorry.

@GrahamcOfBorg test mediawiki

@aanderse aanderse merged commit 5445b8d into NixOS:master May 1, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.mediawiki on aarch64-linux Success
Details
tests.mediawiki on x86_64-linux Success
Details
@aanderse
Copy link
Contributor

aanderse commented May 1, 2020

Thanks @mmilata 🎉

@mmilata mmilata deleted the mmilata:mediawiki-default-extensions branch May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.