Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 #83451

Merged
merged 1 commit into from Mar 27, 2020

Conversation

@Valodim
Copy link
Contributor

@Valodim Valodim commented Mar 26, 2020

Motivation for this change

The upstream package includes test in the build. Patched that out and informed upstream, should be possible to drop the prePatch then. See kbr/fritzconnection#39

Closes #83384

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Fits CONTRIBUTING.md.
@Valodim Valodim requested review from FRidh and jonringer as code owners Mar 26, 2020
@ofborg ofborg bot added the 6.topic: python label Mar 26, 2020
@Valodim Valodim force-pushed the Valodim:fritzconnection-1.2.1 branch from a3b990d to c72cfbe Mar 26, 2020
@ofborg ofborg bot requested a review from dotlambda Mar 26, 2020
@Valodim Valodim force-pushed the Valodim:fritzconnection-1.2.1 branch from c72cfbe to ddd5fdb Mar 26, 2020
@ofborg ofborg bot added the 8.has: clean-up label Mar 26, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Mar 27, 2020

@GrahamcOfBorg build pythonPackages.fritzconnection

@FRidh
Copy link
Member

@FRidh FRidh commented Mar 27, 2020

@GrahamcOfBorg build python3Packages.fritzconnection

@FRidh FRidh merged commit e3ccc89 into NixOS:master Mar 27, 2020
19 checks passed
19 checks passed
pythonPackages.fritzconnection on aarch64-linux No attempt
Details
pythonPackages.fritzconnection on x86_64-darwin No attempt
Details
pythonPackages.fritzconnection on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.fritzconnection on aarch64-linux Success
Details
python3Packages.fritzconnection on x86_64-darwin Success
Details
python3Packages.fritzconnection on x86_64-linux Success
Details
@Valodim Valodim deleted the Valodim:fritzconnection-1.2.1 branch May 1, 2020
@jokogr jokogr mentioned this pull request May 21, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.