Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Motivation for this change
Only a draft for discoverability (not sure if that makes sense, but there where a few requests already and maybe someone would like to use it already).
I've tested it and it works but the software itself seems still alpha/beta quality and I don't think it's ready for Nixpkgs yet (it doesn't crash, but there are some rendering issues, the overlay doesn't disappear automatically after a few secondes, etc. and we should wait for a tagged (pre-)release anyway).
Hello, I'm a bot and I thank you in the name of the community for your contributions.
Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.
If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:
If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.
If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.
If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.
Kinda. It should still be maintained (especially if you send Drew a patch) but there isn't any active development anymore. However, while it's probably feature complete it doesn't really seem that usable/polished yet. And without a tagged release (which I was hoping for after a few more patches) it doesn't really make much sense to merge this into Nixpkgs.
But it seems like e.g. Fedora packages it already: https://repology.org/project/wshowkeys/versions
Yeah, I'm not aware of any alternatives and it can clearly be useful. But a tagged release would be helpful, though not required.
That would be helpful as I didn't really need it myself so far.
Ok, I finally asked Drew via IRC and he's fine with it :)