Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wshowkeys: init at 2020-03-29 #83687

Merged
merged 2 commits into from Oct 27, 2020
Merged

wshowkeys: init at 2020-03-29 #83687

merged 2 commits into from Oct 27, 2020

Conversation

@primeos
Copy link
Member

@primeos primeos commented Mar 29, 2020

Motivation for this change

Only a draft for discoverability (not sure if that makes sense, but there where a few requests already and maybe someone would like to use it already).

I've tested it and it works but the software itself seems still alpha/beta quality and I don't think it's ready for Nixpkgs yet (it doesn't crash, but there are some rendering issues, the overlay doesn't disappear automatically after a few secondes, etc. and we should wait for a tagged (pre-)release anyway).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@stale
Copy link

@stale stale bot commented Sep 25, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Sep 25, 2020
@primeos primeos closed this Sep 27, 2020
@berbiche
Copy link
Contributor

@berbiche berbiche commented Oct 5, 2020

@primeos Was this closed because wshowkeys seems unmaintained?

@primeos
Copy link
Member Author

@primeos primeos commented Oct 5, 2020

Kinda. It should still be maintained (especially if you send Drew a patch) but there isn't any active development anymore. However, while it's probably feature complete it doesn't really seem that usable/polished yet. And without a tagged release (which I was hoping for after a few more patches) it doesn't really make much sense to merge this into Nixpkgs.

But it seems like e.g. Fedora packages it already: https://repology.org/project/wshowkeys/versions

Copy link
Contributor

@berbiche berbiche left a comment

I think this package is relevant to the wayland community and should be reopened.
I propose adding myself to the list of maintainers if you wish.

nixos/modules/programs/wshowkeys.nix Show resolved Hide resolved
@primeos
Copy link
Member Author

@primeos primeos commented Oct 7, 2020

I think this package is relevant to the wayland community and should be reopened.

Yeah, I'm not aware of any alternatives and it can clearly be useful. But a tagged release would be helpful, though not required.
I'll reopen this PR for now but it's probably a good idea to quickly ask Drew first if it's ok to package this already.

I propose adding myself to the list of maintainers if you wish.

That would be helpful as I didn't really need it myself so far.

@primeos primeos reopened this Oct 7, 2020
primeos and others added 2 commits Mar 23, 2020
@primeos primeos force-pushed the primeos:wshowkeys branch from a09a08c to b4bca7b Oct 18, 2020
@stale stale bot removed the 2.status: stale label Oct 18, 2020
@primeos primeos changed the title wshowkeys: init at 2019-09-26 wshowkeys: init at 2020-03-29 Oct 18, 2020
@primeos
Copy link
Member Author

@primeos primeos commented Oct 18, 2020

I'll reopen this PR for now but it's probably a good idea to quickly ask Drew first if it's ok to package this already.

Ok, I finally asked Drew via IRC and he's fine with it :)
So this is now ready for a final review and merging (if there aren't any objections).

@primeos primeos marked this pull request as ready for review Oct 18, 2020
@ryantm
Copy link
Member

@ryantm ryantm commented Oct 27, 2020

Result of nixpkgs-review pr 83687 1

1 package blacklisted:
- tests.nixos-functions.nixos-test
1 package built:
- wshowkeys
@ryantm
ryantm approved these changes Oct 27, 2020
@ryantm ryantm merged commit 178d373 into NixOS:master Oct 27, 2020
19 of 20 checks passed
19 of 20 checks passed
tests
Details
action
Details
wshowkeys, wshowkeys.passthru.tests on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4bca7b"; rev="b4bca7b85c162aec8cb5bf0399897adaae0bc41a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4bca7b"; rev="b4bca7b85c162aec8cb5bf0399897adaae0bc41a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4bca7b"; rev="b4bca7b85c162aec8cb5bf0399897adaae0bc41a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4bca7b"; rev="b4bca7b85c162aec8cb5bf0399897adaae0bc41a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4bca7b"; rev="b4bca7b85c162aec8cb5bf0399897adaae0bc41a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4bca7b"; rev="b4bca7b85c162aec8cb5bf0399897adaae0bc41a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b4bca7b"; rev="b4bca7b85c162aec8cb5bf0399897adaae0bc41a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
wshowkeys, wshowkeys.passthru.tests on aarch64-linux Success
Details
wshowkeys, wshowkeys.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.