Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.wolframclient: init at 1.1.2 #83892

Closed
wants to merge 1 commit into from

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Mar 31, 2020

Motivation for this change

Include Wolfram's Mathematica client library - https://github.com/WolframResearch/WolframClientForPython .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar doronbehar requested review from FRidh and jonringer as code owners Mar 31, 2020
@doronbehar doronbehar force-pushed the package-wolframclient branch from bc62cd7 to e4bb518 Mar 31, 2020
@doronbehar doronbehar force-pushed the package-wolframclient branch from e4bb518 to 29cb069 Mar 31, 2020
Copy link
Contributor

@jonringer jonringer left a comment

I'm not sure this actually runs, I got the tests going using pytestCheckHook

self = <[AttributeError("'WolframKernelController' object has no attribute '_state_lock'") raised in repr()] WolframKernelController object at 0x7ffff5867d50>
kernel = None, initfile = None, consumer = None, kernel_loglevel = 20
stdin = -1, stdout = -1, stderr = -1, kwargs = {}

    def __init__(
        self,
        kernel=None,
        initfile=None,
        consumer=None,
        kernel_loglevel=logging.NOTSET,
        stdin=PIPE,
        stdout=PIPE,
        stderr=PIPE,
        **kwargs
    ):
        self.id = _thread_counter()
        super().__init__(name="wolfram-kernel-%i" % self.id)

        self.kernel = kernel or self.default_kernel_path()

        if self.kernel:

            if not os.isfile(self.kernel):
                raise WolframKernelException("Kernel not found at %s." % self.kernel)

            if not os.access(self.kernel, os.X_OK):
                raise WolframKernelException("Cannot execute kernel %s." % self.kernel)

        else:
            raise WolframKernelException(
>               "Cannot locate a kernel automatically. Please provide an explicit kernel path."
            )
E           wolframclient.exception.WolframKernelException: Cannot locate a kernel automatically. Please provide an explicit kernel path.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 31, 2020

the package should probably be patched so that the correct kernel can be called.

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Mar 31, 2020

Hmm that makes sense but that would make this package depend unconditionally on mathematica which is unfree and requires a license. This isn't right if you ask me since it is possible to use this package with a "cloud" session - which requires a different license, see https://reference.wolfram.com/language/WolframClientForPython/docpages/basic_usages.html#wolfram-cloud-interactions

Unless @jonringer you think we can use ${mathematica}/kernel or what ever without referencing it.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 1, 2020

I think it depends, is this package usable?

Also, is it worth the maintenance burden to be in nixpkgs?

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Apr 1, 2020

I think it depends, is this package usable?

I managed to use it with my student pro account and with a cloud session as they explain in that doc link. As for the default path for the kernel - I'm sure users who have the kernel (nixos.mathematica) installed will manage to find the right path for an offline session.

Also, is it worth the maintenance burden to be in nixpkgs?

Personally, I see my self using it in the future somehow - I like the capabilities of Wolfram / Mathematica and I feel very comfortable with Python - hence I think it'd be nice if we'll include it :).

@jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 1, 2020

sure, but for pure python packages, it's very easy to just do nix-shell -p python3; python -m venv venv; ./venv/bin/activate ; pip install wolframclient

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Apr 2, 2020

Well then, I guess you could say that for every new pure Python package ever added to NixOS :). Overlays could be used to make that command even simpler as nix-shell -p python3-wolframclient-env... I'm just interested in sharing this with the NixOS community while I take myself the full responsibility of maintaining it.

Note that the package seems active with a broad set of users and it is developed officially by the Wolfram developers team.

@stale
Copy link

@stale stale bot commented Sep 29, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@doronbehar
Copy link
Contributor Author

@doronbehar doronbehar commented Sep 29, 2020

It's not that important, I'll close.

@doronbehar doronbehar closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants