Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skim: fix vim-plugin output #83915

Merged
merged 1 commit into from Aug 2, 2020
Merged

Conversation

@tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Apr 1, 2020

Motivation for this change

skim has both a utility and vim-plugin (skim.vim)
The vim-plugin is split where part of it is installed by skim, the rest is installed by skim.vim.
This is very similar to fzf and fzf.vim. In fact, skim.vim is a fork of fzf.vim.

Add vimPlugin.skim-vim which depends on vimPlugin.skim.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tsaeger
Copy link
Contributor Author

@tsaeger tsaeger commented Apr 1, 2020

@dywedir review?

@jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 1, 2020

@tsaeger tsaeger force-pushed the tsaeger:tsaeger/skim-fix-vim-plugin branch 2 times, most recently from 4afd45a to 087b942 Apr 1, 2020
@tsaeger tsaeger requested a review from jonringer as a code owner Apr 2, 2020
@ofborg ofborg bot requested a review from dywedir Apr 2, 2020
@tsaeger tsaeger force-pushed the tsaeger:tsaeger/skim-fix-vim-plugin branch from 087b942 to a56a24c Apr 3, 2020
@tsaeger
Copy link
Contributor Author

@tsaeger tsaeger commented Apr 11, 2020

Thinking I might re-rework this. Keep the "vim" outputs path in "skim".
Keep vimPlugins.skim and just merely add vimPlugins.skim-vim.

Copy link
Contributor

@jonringer jonringer left a comment

there should also be an entry in vim-plugin-names

@tsaeger tsaeger force-pushed the tsaeger:tsaeger/skim-fix-vim-plugin branch from f5a54f4 to 991221f Apr 13, 2020
@tsaeger
Copy link
Contributor Author

@tsaeger tsaeger commented Apr 13, 2020

@jonringer thanks for the link! I've fixed the pr to include entry in vim-plugin-names.

@8573
Copy link
Contributor

@8573 8573 commented Aug 2, 2020

What more needs to be done for this to be merged?

@Mic92 Mic92 merged commit f50b820 into NixOS:master Aug 2, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991221f"; rev="991221f9aa98ae578f915edc3d0a47b9b14a57c5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991221f"; rev="991221f9aa98ae578f915edc3d0a47b9b14a57c5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991221f"; rev="991221f9aa98ae578f915edc3d0a47b9b14a57c5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991221f"; rev="991221f9aa98ae578f915edc3d0a47b9b14a57c5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991221f"; rev="991221f9aa98ae578f915edc3d0a47b9b14a57c5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991221f"; rev="991221f9aa98ae578f915edc3d0a47b9b14a57c5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="991221f"; rev="991221f9aa98ae578f915edc3d0a47b9b14a57c5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.