Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
gnuradio: 126.96.36.199 -> 188.8.131.52 & more #84401
Motivation for this change
Address most of the ideas in #82263 without introducing gnuradio 3.8 yet.
Use enable<This> flags to enable / disable features. Currently all features are enabled, to test the build. Add some TODOs for missing stuff.
Impressive work! Some questions:
Very likely. Moreover, it should be possible to make all of the components-cmakeFlags-dependencies mechanism work better and in a more declarative manner. Perhaps similarly to mpd.
I wasn't as experienced in Nix expressions as I'm today (after working on #85103) when I wrote this PR, so I'll have to work on this further.
It's not that many :) the
This is somewhat off topic for this PR but I think it's still appropriate: Generally, ever since I started contributing to Nixpkgs, it really frustrated me that you have to compile a whole derivation from scratch just because something is not working as you wish in the fixup phase where the outputs are split. I consider this a developer-experience issue of Nixpkgs it self, though I have absolutely no idea how to tackle it.
So to summarize my answer to your question, I'm not objected to split the outputs, but I'm not up to do it :/.
I agree, but I assume the release notes should be updated then? I'll take care of that once the whole PR is truly ready and more information will be required there.
Besides that, just to note my self and anyone else, GNU Radio 3.8's wrapper is not ready yet. I've learned a lot about wrappers after working on #85103 so I should be able to fix GNU Radio's wrapping as well at some point.
@doronbehar I really like some of the improvements in this PR.
What do you think about reducing the scope a little bit? For example, if 3.8 isn't really ready yet, we don't necessarily need to introduce it (and fixing more things is easier, as there's less code).
Thanks for the encouragement @flokli . I agree it's a good idea, I was putting it all together in a single PR because I was in a sprint. If I'll split this, I hope it'll be OK to ping you in each such PR for your review.
As a start, I need your help with #84243
After that, I'll write a PR that will do nothing besides formatting the inputs and the arguments of the current
You should note, that today, in current master, GNUradio's frontend is essentially broken - see #87510 so don't get the impression that the near PRs will fix it - the problem is in the wrapper and it should be taken care of only when the plugins and many other changes will be sorted out.
A dumb version bump: gnuradio: 184.108.40.206 -> 220.127.116.11 as in 92dadf5 + checking with
Let's talk more after these 2 PRs will be completed. I'll close this PR in the meantime, though it's still good as a reference.