Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lutris/proton depends on security lib #84420

Merged

Conversation

@RohanHart
Copy link
Contributor

RohanHart commented Apr 6, 2020

Motivation for this change

Proton 5 runtime will not start due to an error in the python wrapper:

ImportError: libselinux.so.1
Things done

extend chroot environment

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
fixes:
    ImportError: libselinux.so.1
@DamienCassou
Copy link
Contributor

DamienCassou commented May 8, 2020

Hi @RohanHart,

is this patch still relevant? How do I reproduce the problem?

@RohanHart
Copy link
Contributor Author

RohanHart commented May 10, 2020

Hi @DamienCassou

Yes, this is still needed in 20.03 and current unstable. To reproduce install Proton 5 via Steam and select it as a Wine runner in Lutris. Any program configured to use the Proton 5 runner will fail very early with:

Traceback (most recent call last):
  File "/nix/store/bn1jcmmf4xphh7q60mddhyacm3wlxq7k-lutris-original-0.5.5/share/lutris/bin/lutris-wrapper", line 16, in <module>
    from lutris.util.log import logger
  File "/nix/store/bn1jcmmf4xphh7q60mddhyacm3wlxq7k-lutris-original-0.5.5/lib/python3.7/site-packages/lutris/util/log.py", line 6, in <module>
    from gi.repository import GLib
  File "/nix/store/p977hjqi6afczl5wx7nn0k7lacys3vvv-python3.7-pygobject-3.36.0/lib/python3.7/site-packages/gi/__init__.py", line 42, in <module>
    from . import _gi
ImportError: libselinux.so.1: cannot open shared object file: No such file or directory
@podiki
Copy link

podiki commented May 12, 2020

Same here on current Arch packages. Installing libselinux solves this.

@DamienCassou
Copy link
Contributor

DamienCassou commented May 13, 2020

Result of nixpkgs-review pr 84420 1

2 packages marked as broken and skipped:
- lutris
- lutris-free
@DamienCassou
Copy link
Contributor

DamienCassou commented May 13, 2020

The package won't build because of a dependency to p7zip but this shouldn't prevent this fix from being merged.

@DamienCassou DamienCassou merged commit 47ea746 into NixOS:master May 13, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d05e15"; rev="2d05e1578122cd1c7ea5991eadceb01e5f1951ef"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d05e15"; rev="2d05e1578122cd1c7ea5991eadceb01e5f1951ef"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d05e15"; rev="2d05e1578122cd1c7ea5991eadceb01e5f1951ef"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d05e15"; rev="2d05e1578122cd1c7ea5991eadceb01e5f1951ef"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d05e15"; rev="2d05e1578122cd1c7ea5991eadceb01e5f1951ef"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d05e15"; rev="2d05e1578122cd1c7ea5991eadceb01e5f1951ef"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2d05e15"; rev="2d05e1578122cd1c7ea5991eadceb01e5f1951ef"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@DamienCassou
Copy link
Contributor

DamienCassou commented May 13, 2020

Arghhh, I forgot to check the commit message before merging. Next time, please follow the standard in the contribution guidelines: https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes.

@RohanHart
Copy link
Contributor Author

RohanHart commented May 13, 2020

So, for future reference that should have been:

lutris: proton 5 runner depends on libselinux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.