Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powershell: 6.2.3 -> 7.0.0 #84454

Closed
wants to merge 1 commit into from
Closed

powershell: 6.2.3 -> 7.0.0 #84454

wants to merge 1 commit into from

Conversation

@SRGOM
Copy link
Member

SRGOM commented Apr 6, 2020

Package and openssl dependency version bump and cascading changes.

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Package and openssl dependency version bump and cascading changes.
@SRGOM
Copy link
Member Author

SRGOM commented Apr 6, 2020

@jonringer @yrashk Please review if you have time.

@jonringer
Copy link
Contributor

jonringer commented Apr 6, 2020

@GrahamcOfBorg build powershell

Copy link
Contributor

jonringer left a comment

LGTM
able to start interpreter

[3 built, 3 copied (2.5 MiB), 0.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84454
1 package built:
powershell
rm $pslibs/libcrypto.so.1.0.0
rm $pslibs/libssl.so.1.0.0
patchelf --replace-needed libcrypto.so.1.0.0 libcrypto.so.1.1 $pslibs/libmi.so
patchelf --replace-needed libssl.so.1.0.0 libssl.so.1.1 $pslibs/libmi.so
Comment on lines +35 to +39

This comment has been minimized.

Copy link
@jonringer

jonringer Apr 6, 2020

Contributor

do you mind making this darwin compatible?

rm: cannot remove '/nix/store/kca66mmwd5sakpa836hmcdz1dqj260ms-powershell-7.0.0/share/powershell/libcrypto.so.1.0.0': No such file or directory
builder for '/nix/store/a3yv0rvwf11jms0i3h5466ph7kmcwfwg-powershell-7.0.0.drv' failed with exit code 1
error: build of '/nix/store/a3yv0rvwf11jms0i3h5466ph7kmcwfwg-powershell-7.0.0.drv' failed

This comment has been minimized.

Copy link
@Mic92

Mic92 May 3, 2020

Contributor

I thought autoPatchelfHook does not exists on macOS at all.

This comment has been minimized.

Copy link
@Mic92

Mic92 May 3, 2020

Contributor

Nevertheless the patchelf code needs to be hidden behind a optionalString !stdenv.isDarwin flag.

This comment has been minimized.

Copy link
@jonringer
@jonringer jonringer mentioned this pull request Apr 30, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.