Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hactool: init at 1.3.3 #84494

Merged
merged 1 commit into from May 3, 2020
Merged

hactool: init at 1.3.3 #84494

merged 1 commit into from May 3, 2020

Conversation

@IvarWithoutBones
Copy link
Contributor

IvarWithoutBones commented Apr 6, 2020

Motivation for this change

Adds hactool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Emantor
Emantor approved these changes Apr 6, 2020
Copy link
Contributor

Emantor left a comment

  • checked license
  • build binaries
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-84494/build.nix
[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84494
1 package built:
hactool
  • program works in so far that it outputs the help section
Copy link
Contributor

Emantor left a comment

Commit message is missing an at: hactool: init at 1.3.2

@IvarWithoutBones IvarWithoutBones force-pushed the IvarWithoutBones:hactool branch from a637ef1 to 864fee2 Apr 6, 2020
@IvarWithoutBones
Copy link
Contributor Author

IvarWithoutBones commented Apr 6, 2020

Commit message is missing an at: hactool: init at 1.3.2

My bad, fixed.

@IvarWithoutBones IvarWithoutBones changed the title hactool: init 1.3.2 hactool: init at 1.3.2 Apr 6, 2020
@Emantor
Emantor approved these changes Apr 6, 2020
@IvarWithoutBones IvarWithoutBones force-pushed the IvarWithoutBones:hactool branch from 864fee2 to 2f13ffd Apr 25, 2020
@IvarWithoutBones IvarWithoutBones changed the title hactool: init at 1.3.2 hactool: init at 1.3.3 Apr 25, 2020
@IvarWithoutBones IvarWithoutBones force-pushed the IvarWithoutBones:hactool branch 2 times, most recently from 96c3434 to c93423d May 1, 2020
@IvarWithoutBones
Copy link
Contributor Author

IvarWithoutBones commented May 1, 2020

Apologies for the messing around, thought that'd compile.

Anything blocking this from getting merged?

Copy link
Contributor

jonringer left a comment

otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/84494
1 package built:
hactool
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@IvarWithoutBones IvarWithoutBones force-pushed the IvarWithoutBones:hactool branch from c93423d to 87abf7d May 3, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 84494 1

1 package built:
- hactool

@jonringer jonringer merged commit 35639c6 into NixOS:master May 3, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87abf7d"; rev="87abf7d88509c407f678ed78350e0a05d4832de3"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87abf7d"; rev="87abf7d88509c407f678ed78350e0a05d4832de3"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87abf7d"; rev="87abf7d88509c407f678ed78350e0a05d4832de3"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87abf7d"; rev="87abf7d88509c407f678ed78350e0a05d4832de3"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87abf7d"; rev="87abf7d88509c407f678ed78350e0a05d4832de3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87abf7d"; rev="87abf7d88509c407f678ed78350e0a05d4832de3"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="87abf7d"; rev="87abf7d88509c407f678ed78350e0a05d4832de3"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
hactool, hactool.passthru.tests on aarch64-linux Success
Details
hactool, hactool.passthru.tests on x86_64-linux Success
Details
@IvarWithoutBones IvarWithoutBones deleted the IvarWithoutBones:hactool branch May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.