Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitron: init at 2020-01-24 #84572

Merged
merged 1 commit into from Oct 19, 2020
Merged

waitron: init at 2020-01-24 #84572

merged 1 commit into from Oct 19, 2020

Conversation

@dguibert
Copy link
Member

@dguibert dguibert commented Apr 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Emantor
Emantor approved these changes Apr 7, 2020
Copy link
Contributor

@Emantor Emantor left a comment

  • checked license
  • build package
[7 built, 4 copied (3.6 MiB), 1.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84572
1 package built:
waitron
  • binary works as far as outputting the help text

Copy link
Contributor

@Emantor Emantor left a comment

Please correctly format the commit waitron: init at 2020-01-24.

@dguibert dguibert force-pushed the dg/init-waitron branch from c5c6ecb to 701ddad Apr 7, 2020
@dguibert
Copy link
Member Author

@dguibert dguibert commented Apr 7, 2020

Please correctly format the commit waitron: init at 2020-01-24.

done (and also changed the title of the issue)

@dguibert dguibert changed the title waitron: init waitron: init at 2020-01-24 Apr 7, 2020
Emantor
Emantor approved these changes Apr 7, 2020
@stale
Copy link

@stale stale bot commented Oct 4, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Oct 4, 2020
@dguibert
Copy link
Member Author

@dguibert dguibert commented Oct 5, 2020

"still important to me"

@stale stale bot removed the 2.status: stale label Oct 5, 2020
@marsam marsam merged commit 597a1e7 into NixOS:master Oct 19, 2020
16 checks passed
16 checks passed
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="701ddad"; rev="701ddad4ce8e56795f7ccd2f34e387b9071e74a7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="701ddad"; rev="701ddad4ce8e56795f7ccd2f34e387b9071e74a7"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="701ddad"; rev="701ddad4ce8e56795f7ccd2f34e387b9071e74a7"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="701ddad"; rev="701ddad4ce8e56795f7ccd2f34e387b9071e74a7"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="701ddad"; rev="701ddad4ce8e56795f7ccd2f34e387b9071e74a7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="701ddad"; rev="701ddad4ce8e56795f7ccd2f34e387b9071e74a7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="701ddad"; rev="701ddad4ce8e56795f7ccd2f34e387b9071e74a7"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
waitron, waitron.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
waitron, waitron.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants