Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlkit: init at 4.5.0 #84730

Merged
merged 1 commit into from Jun 23, 2020
Merged

mlkit: init at 4.5.0 #84730

merged 1 commit into from Jun 23, 2020

Conversation

@athas
Copy link
Contributor

athas commented Apr 8, 2020

Motivation for this change

I don't think Nixpkgs contains quite enough Standard ML compilers. Here's one more. It's actively maintained and in use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/mlkit/default.nix Outdated Show resolved Hide resolved
@athas athas force-pushed the athas:mlkit branch from 95b81ed to f35091e Apr 8, 2020
@athas
Copy link
Contributor Author

athas commented Apr 8, 2020

Thanks for the prompt review! Replacing the buildPhase with makeFlags unfortunately doesn't work, likely because the Makefile has imperfect dependencies. make mlkit must finish completely before running make mlkib_libs.

@athas athas requested a review from FRidh Apr 8, 2020
@athas athas changed the title mlkit: init at 4.4.3 mlkit: init at 4.5.0 Apr 30, 2020
@athas athas force-pushed the athas:mlkit branch from f35091e to f814995 Apr 30, 2020
@athas
Copy link
Contributor Author

athas commented Apr 30, 2020

I have updated the derivation to use the just released mlkit 4.5.0, and also simplified the handling of autoconf.

@multun
multun approved these changes Jun 21, 2020
@athas athas force-pushed the athas:mlkit branch from f814995 to cfe9316 Jun 21, 2020
@athas
Copy link
Contributor Author

athas commented Jun 21, 2020

I quoted the homepage URL, as I was told that unquoted URLs are now deprecated.

@athas athas force-pushed the athas:mlkit branch from cfe9316 to 03c8af2 Jun 22, 2020
@athas athas force-pushed the athas:mlkit branch from 03c8af2 to ae6d1a9 Jun 22, 2020
@multun
multun approved these changes Jun 22, 2020
@athas athas force-pushed the athas:mlkit branch from ae6d1a9 to 0ffeccd Jun 23, 2020
Copy link
Member

danieldk left a comment

LGTM, thanks!

Result of nixpkgs-review pr 84730 1

1 package built:
- mlkit
$ mlkit --version
MLKit  (2020-06-23T-07:29:35) [X64 Backend]
 mlkit life.sml 
[wrote X64 code file:	MLB/RI_GC/base-link_objects.s]
[wrote executable file:	run]
@danieldk danieldk merged commit 28d2854 into NixOS:master Jun 23, 2020
16 checks passed
16 checks passed
mlkit, mlkit.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0ffeccd"; rev="0ffeccd89fd1d1aaeb1285827362179a3b9a4451"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0ffeccd"; rev="0ffeccd89fd1d1aaeb1285827362179a3b9a4451"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0ffeccd"; rev="0ffeccd89fd1d1aaeb1285827362179a3b9a4451"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0ffeccd"; rev="0ffeccd89fd1d1aaeb1285827362179a3b9a4451"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0ffeccd"; rev="0ffeccd89fd1d1aaeb1285827362179a3b9a4451"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0ffeccd"; rev="0ffeccd89fd1d1aaeb1285827362179a3b9a4451"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0ffeccd"; rev="0ffeccd89fd1d1aaeb1285827362179a3b9a4451"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mlkit, mlkit.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.