Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openafs_1_8: 1.8.5 -> 1.8.6 #84968

Merged
merged 1 commit into from Jun 30, 2020
Merged

openafs_1_8: 1.8.5 -> 1.8.6 #84968

merged 1 commit into from Jun 30, 2020

Conversation

@andersk
Copy link
Contributor

andersk commented Apr 11, 2020

Motivation for this change

Now that linux_latest is 5.6, OpenAFS fails to build without these changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • Succeeded: linuxPackages-libre.openafs_1_8 linuxPackages.openafs_1_8 linuxPackages_4_14.openafs_1_8 linuxPackages_4_19.openafs_1_8 linuxPackages_4_4.openafs_1_8 linuxPackages_4_9.openafs_1_8 linuxPackages_5_5.openafs_1_8 linuxPackages_5_6.openafs_1_8 linuxPackages_latest-libre.openafs_1_8 linuxPackages_latest_xen_dom0.openafs_1_8 linuxPackages_xen_dom0.openafs_1_8 openafs_1_8.

      Failed: linuxPackages_hardened.openafs_1_8 linuxPackages_latest_hardened.openafs_1_8 linuxPackages_latest_xen_dom0_hardened.openafs_1_8 linuxPackages_testing_bcachefs.openafs_1_8 linuxPackages_testing_hardened.openafs_1_8 linuxPackages_xen_dom0_hardened.openafs_1_8.

      (The incompatibility with the hardened variant is not a regression.)

  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Cc @maggesi @spacefrogg

Copy link
Contributor

spacefrogg left a comment

I would like to defer this until the 1.8.6 release or at least split it off such that 1.8.5 is used on compatible kernels and 1.8.6pre* is used only on 5.6 kernels. When deployed, AFS is usually a central piece of infrastructure and pre-releases had issues in the past. So, I wouldn't like to surprise anyone with a breaking minor release update.

@andersk andersk force-pushed the andersk:openafs branch from 0b1a458 to e254b5b May 5, 2020
@andersk andersk changed the title openafs_1_8: 1.8.5 -> 1.8.6pre1, add upstream patches for Linux kernel 5.6 support openafs_1_8: 1.8.5 -> 1.8.6pre2 May 5, 2020
@Mic92
Copy link
Contributor

Mic92 commented May 21, 2020

Does 1.8.6pre2 works with 1.8.5 userland? Than we can make the module depending on the kernel version.

@Mic92
Copy link
Contributor

Mic92 commented May 21, 2020

I made a PR that only cherry-pick the 5.6er fixes into openafs: #88552

@spacefrogg
Copy link
Contributor

spacefrogg commented May 22, 2020

Does 1.8.6pre2 works with 1.8.5 userland? Than we can make the module depending on the kernel version.

It usually works out. It is, though, neither supported nor recommended by upstream. Given the significance of a working AFS, my comment above still applies. I would suggest marking it broken on 5.6 kernels until 1.8.6 is released. It would only disturb client updates and no pure server setups.

I know this is an nuisance and it is successfully haunting distribution maintainers since the first release of OpenAFS. Let's hope for kafs...

@Mic92
Copy link
Contributor

Mic92 commented May 23, 2020

Can we close this and wait for the next proper release of openafs?

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk force-pushed the andersk:openafs branch from e254b5b to e38494a Jun 30, 2020
@andersk andersk changed the title openafs_1_8: 1.8.5 -> 1.8.6pre2 openafs_1_8: 1.8.5 -> 1.8.6 Jun 30, 2020
@andersk
Copy link
Contributor Author

andersk commented Jun 30, 2020

1.8.6 is released now; updated.

@andersk andersk requested a review from spacefrogg Jun 30, 2020
@Mic92 Mic92 merged commit 7db1465 into NixOS:master Jun 30, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e38494a"; rev="e38494a8da0ed7d8fd8660bb88d5e7dd15dace83"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e38494a"; rev="e38494a8da0ed7d8fd8660bb88d5e7dd15dace83"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e38494a"; rev="e38494a8da0ed7d8fd8660bb88d5e7dd15dace83"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e38494a"; rev="e38494a8da0ed7d8fd8660bb88d5e7dd15dace83"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e38494a"; rev="e38494a8da0ed7d8fd8660bb88d5e7dd15dace83"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e38494a"; rev="e38494a8da0ed7d8fd8660bb88d5e7dd15dace83"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e38494a"; rev="e38494a8da0ed7d8fd8660bb88d5e7dd15dace83"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
openafs_1_8, openafs_1_8.passthru.tests on aarch64-linux Success
Details
openafs_1_8, openafs_1_8.passthru.tests on x86_64-linux Success
Details
@Mic92 Mic92 mentioned this pull request Jun 30, 2020
5 of 10 tasks complete
@Mic92
Copy link
Contributor

Mic92 commented Jun 30, 2020

We might want to backport this to 20.03 because linux 5.7 is also present there.

@andersk andersk mentioned this pull request Jun 30, 2020
3 of 10 tasks complete
@andersk
Copy link
Contributor Author

andersk commented Jun 30, 2020

Opened #91867 for the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.